Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org, dje@google.com
Subject: Re: [patch+7.5] auto-load: User conveniences suggested by Doug Evans
Date: Mon, 10 Sep 2012 13:06:00 -0000	[thread overview]
Message-ID: <504DE5CD.7070707@redhat.com> (raw)
In-Reply-To: <20120910114726.GA9118@host2.jankratochvil.net>

On 09/10/2012 12:47 PM, Jan Kratochvil wrote:
> On Mon, 10 Sep 2012 13:29:19 +0200, Pedro Alves wrote:
>> On 09/09/2012 10:01 AM, Jan Kratochvil wrote:
>>> For more information about this security protection see
>>> the "Auto-loading safe path" section in the GDB manual or run from the shell:
>>> 	info "(gdb)Auto-loading safe path"
>>> warning: File "/home/jkratoch/redhat/gdb-clean/gdb/gdb-gdb.py" auto-loading has been declined by your `auto-load safe-path' set to "$debugdir:$datadir/auto-load".
>>
>> I honestly don't understand why "for example, run..." would be worse
>> than "or run...", while "or" to my ears implies that the information that
>> you get in the pointed section of the manual might be different (alternative)
>> from what you get from that info command.  But that's maybe just language
>> barrier, or just me.  I'm happy enough with this version.  Thanks.
> 
> I understand "for example" would be slightly better there but it IMO is not
> worth an extra line.

If that's the issue, "e.g.," is shorter, and moving the "the" to the
previous line still leaves us at 78 columns:

For more information about this security protection see the
"Auto-loading safe path" section in the GDB manual.  E.g., run from the shell:
	info "(gdb)Auto-loading safe path"

vs the 77 columns:

For more information about this security protection see
the "Auto-loading safe path" section in the GDB manual or run from the shell:
 	info "(gdb)Auto-loading safe path"

Not suggesting this one, but a little re-flowing can bring it down to 73 columns,
at the expense of breaking the section name in two lines:

For more information about this security protection see the "Auto-loading
safe path" section in the GDB manual. For example, run from the shell:
	info "(gdb)Auto-loading safe path"

Anyway, just for completeness.  Thanks.

> 
> I believe the output should not be too long to be read by anyone.
> I understand the warning in 7.5 has proven to be too short, though.
> 
> For example the initial GDB licensing information (without -q) is too long,
> I do not see it required by GNU Coding Standards; but the initial text is
> offtopic here.

-- 
Pedro Alves


  reply	other threads:[~2012-09-10 13:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 14:44 Jan Kratochvil
2012-08-21 17:50 ` Eli Zaretskii
2012-08-24 16:11   ` Jan Kratochvil
2012-08-24 18:15     ` Eli Zaretskii
2012-09-09  8:53       ` Jan Kratochvil
2012-09-09 17:26         ` Eli Zaretskii
2012-09-09 17:55           ` Jan Kratochvil
2012-09-09 18:09             ` Eli Zaretskii
2012-08-22 15:46 ` Pedro Alves
2012-08-24 15:13   ` Jan Kratochvil
2012-08-24 15:17     ` Pedro Alves
2012-08-24 15:19   ` Eli Zaretskii
2012-08-24 15:28     ` Pedro Alves
2012-08-24 15:31       ` Pedro Alves
2012-08-24 15:43         ` Jan Kratochvil
2012-08-24 17:56         ` Eli Zaretskii
2012-08-24 18:01           ` Jan Kratochvil
2012-08-24 18:26             ` Eli Zaretskii
2012-08-27 18:02               ` Pedro Alves
2012-08-27 18:12                 ` Jan Kratochvil
2012-09-09  9:02                   ` Jan Kratochvil
2012-09-10 11:29                     ` Pedro Alves
2012-09-10 11:47                       ` Jan Kratochvil
2012-09-10 13:06                         ` Pedro Alves [this message]
2012-09-10 15:28                           ` Jan Kratochvil
2012-09-17 18:29                             ` [commit+7.5] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504DE5CD.7070707@redhat.com \
    --to=palves@redhat.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox