From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26882 invoked by alias); 9 Sep 2012 08:53:39 -0000 Received: (qmail 26866 invoked by uid 22791); 9 Sep 2012 08:53:38 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 09 Sep 2012 08:53:21 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q898rJqK012254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 9 Sep 2012 04:53:19 -0400 Received: from host2.jankratochvil.net (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q898rDv1011787 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 9 Sep 2012 04:53:15 -0400 Date: Sun, 09 Sep 2012 08:53:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: gdb-patches@sourceware.org, dje@google.com Subject: Re: [patch+7.5] auto-load: User conveniences suggested by Doug Evans Message-ID: <20120909085312.GA4994@host2.jankratochvil.net> References: <20120821144355.GA28426@host2.jankratochvil.net> <83k3wsb0da.fsf@gnu.org> <20120824161059.GC7200@host2.jankratochvil.net> <838vd4gns3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838vd4gns3.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00092.txt.bz2 On Fri, 24 Aug 2012 20:14:52 +0200, Eli Zaretskii wrote: > > > > + scripts_directory_help = xstrprintf (_("\ > > > > +Automatically loaded %s%s%sGDB scripts\n\ > > > > +(named OBJFILE%s) are located in one of the directories listed by this\n\ > > > > +option.\n\ > > > > +This option is ignored for the kinds of scripts \ > > > > +having 'set auto-load ... off'.\n\ > > > > +Directories listed here need to be present also \ > > > > +in the 'set auto-load safe-path'\n\ > > > > +option."), > > > > > > Here, the lines are unnecessarily too short, IMO. > > > > I think there should be some clear decision what should the GDB output conform > > to. In this and the paragraph above we have exactly opposite opinions whether > > to wrap the text or not. > > The above simply looks aesthetically wrong to me. Whatever standards > we set, they should first and foremost be presentable. I find the source form of the help text confusing the discussion here, let's talk about the output only. Formatting of the output into the source file does not matter much I think. --with python form: (gdb) help set auto-load scripts-directory Set the list of directories from which to load auto-loaded scripts. Automatically loaded Python scripts (named OBJFILE-gdb.py) and GDB scripts (named OBJFILE-gdb.gdb) are located in one of the directories listed by this option. This option is ignored for the kinds of scripts having 'set auto-load ... off'. Directories listed here need to be present also in the 'set auto-load safe-path' option. --without-python form: (gdb) help set auto-load scripts-directory Set the list of directories from which to load auto-loaded scripts. Automatically loaded GDB scripts (named OBJFILE-gdb.gdb) are located in one of the directories listed by this option. This option is ignored for the kinds of scripts having 'set auto-load ... off'. Directories listed here need to be present also in the 'set auto-load safe-path' option. Do you find anything aesthetically wrong with this output form and could you suggest specific changes? --without-python form is not perfect but I find it good enough for the less common case of builds. Thanks, Jan