Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org, Stan Shebs <stanshebs@earthlink.net>,
	       Tom Tromey <tromey@redhat.com>
Subject: Re: 7.4->7.5 Regression gdb.base/pending.exp with gdbserver  [Re: [PATCH] Dynamic printf for a target agent]
Date: Wed, 25 Jul 2012 19:50:00 -0000	[thread overview]
Message-ID: <20120725195017.GA31204@host2.jankratochvil.net> (raw)
In-Reply-To: <2625393.59PdMiRRzQ@qiyao.dyndns.org>

On Fri, 20 Jul 2012 04:27:59 +0200, Yao Qi wrote:
> It seems incorrect to remove "*dataptr != 'X'" out of this condition checking.
> 
> With the breakpoint commands added, the Z packet becomes
> 
>   "Z0xxxxXxxxx,Xxxxx;cmds:xxxxx"
> 
> When parsing this packet, in current (wrong) GDBserver, only the first
> condition ('Xxxxx') in packet is added, and the rest of conditions are skipped,
> which is a mistake.

xxxx may contain only hex bytes or ',' so it should be safe.


> 2012-07-20  Yao Qi  <yao@codesourcery.com>
> 
> 	* server.c (process_point_options): Stop at 'X' when parsing.

I find this change safe for check-in so OK.


Thanks for the fix,
Jan


  reply	other threads:[~2012-07-25 19:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  1:10 [PATCH] Dynamic printf for a target agent Stan Shebs
2012-05-31  6:02 ` Yao Qi
2012-06-25 15:31   ` Stan Shebs
2012-06-27 20:45     ` Tom Tromey
2012-07-02 18:19       ` Stan Shebs
2012-07-18 19:18         ` 7.4->7.5 Regression gdb.base/pending.exp with gdbserver [Re: [PATCH] Dynamic printf for a target agent] Jan Kratochvil
2012-07-20  2:28           ` Yao Qi
2012-07-25 19:50             ` Jan Kratochvil [this message]
2012-07-27  2:32               ` [committed]: " Yao Qi
2012-07-27 16:36             ` Pedro Alves
2012-07-28 10:24               ` Yao Qi
2012-07-28 11:41                 ` Yao Qi
2012-07-02 16:41     ` Build regression on 64-bit hosts " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120725195017.GA31204@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=stanshebs@earthlink.net \
    --cc=tromey@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox