From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10912 invoked by alias); 25 Jul 2012 19:50:48 -0000 Received: (qmail 10902 invoked by uid 22791); 25 Jul 2012 19:50:47 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 19:50:33 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PJoRUi018406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Jul 2012 15:50:28 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6PJoNwc019944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 25 Jul 2012 15:50:26 -0400 Date: Wed, 25 Jul 2012 19:50:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org, Stan Shebs , Tom Tromey Subject: Re: 7.4->7.5 Regression gdb.base/pending.exp with gdbserver [Re: [PATCH] Dynamic printf for a target agent] Message-ID: <20120725195017.GA31204@host2.jankratochvil.net> References: <4FC57340.6070306@earthlink.net> <4FF1E5FA.2010801@earthlink.net> <20120718191741.GA13886@host2.jankratochvil.net> <2625393.59PdMiRRzQ@qiyao.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2625393.59PdMiRRzQ@qiyao.dyndns.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00579.txt.bz2 On Fri, 20 Jul 2012 04:27:59 +0200, Yao Qi wrote: > It seems incorrect to remove "*dataptr != 'X'" out of this condition checking. > > With the breakpoint commands added, the Z packet becomes > > "Z0xxxxXxxxx,Xxxxx;cmds:xxxxx" > > When parsing this packet, in current (wrong) GDBserver, only the first > condition ('Xxxxx') in packet is added, and the rest of conditions are skipped, > which is a mistake. xxxx may contain only hex bytes or ',' so it should be safe. > 2012-07-20 Yao Qi > > * server.c (process_point_options): Stop at 'X' when parsing. I find this change safe for check-in so OK. Thanks for the fix, Jan