Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: dje@google.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA, doc RFA] New option set use-deprecated-index-sections
Date: Tue, 17 Jul 2012 21:43:00 -0000	[thread overview]
Message-ID: <20120717214257.GA9394@host2.jankratochvil.net> (raw)
In-Reply-To: <yjt28vei2iag.fsf@ruffy2.mtv.corp.google.com>

On Tue, 17 Jul 2012 23:23:51 +0200, dje@google.com wrote:
> I was going to wait to apply this until after 7.5,
> but with the new "-iex" option I realize that the new
> "--use-deprecated-index-sections" option could be considered redundant.
> So I'm thinking about deleting that as well, in favor of having just this.

I would find less GDB options to be good.


> +@item set use-deprecated-index-sections
> +@kindex set use-deprecated-index-sections
> +Set this option to control the treatment of deprecated index sections.
> +When @code{on}, index sections are used even if they are deprecated.

> +When @code{off}, only current versions of index sections are used.
> +The default is @code{off}.

This is not completely correct:
  if (version < 6 && !use_deprecated_index_sections)
  if (version > 7)

So version 6 is not "current" but it is still used even without
-use-deprecated-index-sections.  At least gdb doc should be exact IMO.

It is also questionable if version 6 should be ignored without
-use-deprecated-index-sections.   I guess the possible performance regression
(against non-index case) is so rare it was not worth ignoring version 6.


Thanks,
Jan


  reply	other threads:[~2012-07-17 21:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 21:24 dje
2012-07-17 21:43 ` Jan Kratochvil [this message]
2012-07-17 22:10   ` Doug Evans
2012-07-18 22:34   ` dje
2012-07-18 23:33     ` Jan Kratochvil
2012-07-18 23:53       ` dje
2012-07-19  7:03         ` Jan Kratochvil
2012-07-19 16:09       ` Eli Zaretskii
2012-07-19 16:28         ` Doug Evans
2012-07-19 16:45           ` Eli Zaretskii
2012-07-19 18:26             ` dje
2012-07-19 19:02               ` Eli Zaretskii
2012-07-20 18:01                 ` dje
2012-07-25 14:33                   ` [patch] testsuite: Fix gdb.mi/* regression on RHEL-6 [Re: [RFA, doc RFA] New option set use-deprecated-index-sections] Jan Kratochvil
2012-07-25 20:36                     ` [commit+7.5] " Jan Kratochvil
2012-07-27 21:39                       ` [commit#2+7.5] " Jan Kratochvil
2012-07-19 16:11     ` [RFA, doc RFA] New option set use-deprecated-index-sections Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120717214257.GA9394@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox