Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: dje@google.com
Cc: gdb-patches@sourceware.org
Subject: [commit#2+7.5] [patch] testsuite: Fix gdb.mi/* regression on RHEL-6  [Re: [RFA, doc RFA] New option set use-deprecated-index-sections]
Date: Fri, 27 Jul 2012 21:39:00 -0000	[thread overview]
Message-ID: <20120727213907.GA22390@host2.jankratochvil.net> (raw)
In-Reply-To: <20120725203604.GC32664@host2.jankratochvil.net>

On Wed, 25 Jul 2012 22:36:04 +0200, Jan Kratochvil wrote:
> On Wed, 25 Jul 2012 16:33:07 +0200, Jan Kratochvil wrote:
> > gdb/testsuite/
> > 2012-07-25  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > 
> > 	Fix testsuite regression after --use-deprecated-index-sections removal.
> > 	* lib/mi-support.exp (gdbindex_warning_re): Update the expect string.
> 
> Checked in the fix part:
> 	http://sourceware.org/ml/gdb-cvs/2012-07/msg00209.html
> and for 7.5:
> 	http://sourceware.org/ml/gdb-cvs/2012-07/msg00210.html

Forgot to review the original Gary' patch

commit c55ff693014c302c8b91b99cee0484751f105e15
Date:   Fri Mar 16 16:47:29 2012 +0000
        PR breakpoints/10738

that the regex string is on two more places.  Fixed those now and checked in:
	http://sourceware.org/ml/gdb-cvs/2012-07/msg00235.html
and for 7.5:
	http://sourceware.org/ml/gdb-cvs/2012-07/msg00236.html


Jan


http://sourceware.org/ml/gdb-cvs/2012-07/msg00235.html

--- src/gdb/testsuite/ChangeLog	2012/07/27 08:09:13	1.3308
+++ src/gdb/testsuite/ChangeLog	2012/07/27 21:34:29	1.3309
@@ -1,3 +1,10 @@
+2012-07-27  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Fix testsuite regression after --use-deprecated-index-sections removal.
+	* gdb.base/annota1.exp (run until main breakpoint): Update the expect
+	string.
+	* gdb.base/async-shell.exp (gdbindex_warning_re): Likewise.
+
 2012-07-27  Yao Qi  <yao@codesourcery.com>
 
 	KFAIL for PR remote/14161.
--- src/gdb/testsuite/gdb.base/annota1.exp	2012/06/21 20:46:21	1.48
+++ src/gdb/testsuite/gdb.base/annota1.exp	2012/07/27 21:34:30	1.49
@@ -133,7 +133,7 @@
 #exp_internal 1
 set binexp [string_to_regexp $binfile]
 gdb_test_multiple "run" "run until main breakpoint" {
-    -re "\r\n\032\032post-prompt\r\nStarting program: $binexp \(\r\nwarning: Skipping \[^\r\n\]+ .gdb_index section in \[^\r\n\]+\)?\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)+\r\n\r\n\032\032starting\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)*\r\n\r\n\032\032breakpoint 1\r\n\r\nBreakpoint 1, \r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n.*annota1.c\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n$main_line\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source.*$srcfile:$main_line:.*:beg:$hex\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped.*$gdb_prompt$" {
+    -re "\r\n\032\032post-prompt\r\nStarting program: $binexp \(\r\nwarning: Skipping \[^\r\n\]+ .gdb_index section in \[^\r\n\]+\r\nDo \"set use-deprecated-index-sections on\" before the file is read\r\nto use the section anyway\\.\)?\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)+\r\n\r\n\032\032starting\(\(\r\n\r\n\032\032frames-invalid\)|\(\r\n\r\n\032\032breakpoints-invalid\)\)*\r\n\r\n\032\032breakpoint 1\r\n\r\nBreakpoint 1, \r\n\032\032frame-begin 0 $hex\r\n\r\n\032\032frame-function-name\r\nmain\r\n\032\032frame-args\r\n \\(\\)\r\n\032\032frame-source-begin\r\n at \r\n\032\032frame-source-file\r\n.*annota1.c\r\n\032\032frame-source-file-end\r\n:\r\n\032\032frame-source-line\r\n$main_line\r\n\032\032frame-source-end\r\n\r\n\r\n\032\032source.*$srcfile:$main_line:.*:beg:$hex\r\n\r\n\032\032frame-end\r\n\r\n\032\032stopped.*$gdb_prompt$" {
 	pass "run until main breakpoint" 
     }
 }
--- src/gdb/testsuite/gdb.base/async-shell.exp	2012/03/16 16:47:33	1.5
+++ src/gdb/testsuite/gdb.base/async-shell.exp	2012/07/27 21:34:30	1.6
@@ -29,7 +29,7 @@
     return -1
 }
 
-set gdbindex_warning_re "warning: Skipping \[^\r\n\]+ \\.gdb_index section \[^\r\n\]*"
+set gdbindex_warning_re "warning: Skipping \[^\r\n\]+ \\.gdb_index section \[^\r\n\]*\r\nDo \"set use-deprecated-index-sections on\" before the file is read\r\nto use the section anyway\\."
 
 gdb_test_no_output "set target-async on "
 gdb_test_no_output "set non-stop on"


  reply	other threads:[~2012-07-27 21:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 21:24 [RFA, doc RFA] New option set use-deprecated-index-sections dje
2012-07-17 21:43 ` Jan Kratochvil
2012-07-17 22:10   ` Doug Evans
2012-07-18 22:34   ` dje
2012-07-18 23:33     ` Jan Kratochvil
2012-07-18 23:53       ` dje
2012-07-19  7:03         ` Jan Kratochvil
2012-07-19 16:09       ` Eli Zaretskii
2012-07-19 16:28         ` Doug Evans
2012-07-19 16:45           ` Eli Zaretskii
2012-07-19 18:26             ` dje
2012-07-19 19:02               ` Eli Zaretskii
2012-07-20 18:01                 ` dje
2012-07-25 14:33                   ` [patch] testsuite: Fix gdb.mi/* regression on RHEL-6 [Re: [RFA, doc RFA] New option set use-deprecated-index-sections] Jan Kratochvil
2012-07-25 20:36                     ` [commit+7.5] " Jan Kratochvil
2012-07-27 21:39                       ` Jan Kratochvil [this message]
2012-07-19 16:11     ` [RFA, doc RFA] New option set use-deprecated-index-sections Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120727213907.GA22390@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox