From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16101 invoked by alias); 17 Jul 2012 21:43:23 -0000 Received: (qmail 16092 invoked by uid 22791); 17 Jul 2012 21:43:22 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Jul 2012 21:43:05 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6HLh3EE001717 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Jul 2012 17:43:04 -0400 Received: from host2.jankratochvil.net (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6HLgxdH032318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 17 Jul 2012 17:43:02 -0400 Date: Tue, 17 Jul 2012 21:43:00 -0000 From: Jan Kratochvil To: dje@google.com Cc: gdb-patches@sourceware.org Subject: Re: [RFA, doc RFA] New option set use-deprecated-index-sections Message-ID: <20120717214257.GA9394@host2.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00244.txt.bz2 On Tue, 17 Jul 2012 23:23:51 +0200, dje@google.com wrote: > I was going to wait to apply this until after 7.5, > but with the new "-iex" option I realize that the new > "--use-deprecated-index-sections" option could be considered redundant. > So I'm thinking about deleting that as well, in favor of having just this. I would find less GDB options to be good. > +@item set use-deprecated-index-sections > +@kindex set use-deprecated-index-sections > +Set this option to control the treatment of deprecated index sections. > +When @code{on}, index sections are used even if they are deprecated. > +When @code{off}, only current versions of index sections are used. > +The default is @code{off}. This is not completely correct: if (version < 6 && !use_deprecated_index_sections) if (version > 7) So version 6 is not "current" but it is still used even without -use-deprecated-index-sections. At least gdb doc should be exact IMO. It is also questionable if version 6 should be ignored without -use-deprecated-index-sections. I guess the possible performance regression (against non-index case) is so rare it was not worth ignoring version 6. Thanks, Jan