Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: gdb-patches@sourceware.org
Cc: vapier@gentoo.org, palves@redhat.com, brobecker@adacore.com
Subject: Re: build error for mn10300-elf sim with your recent commit
Date: Sun, 17 Jun 2012 18:57:00 -0000	[thread overview]
Message-ID: <201206171857.q5HIvcPk004487@ignucius.se.axis.com> (raw)
In-Reply-To: <201206160509.q5G59RJX004949@ignucius.se.axis.com> (message from	Hans-Peter Nilsson on Sat, 16 Jun 2012 07:09:27 +0200)

> From: Hans-Peter Nilsson <hp@axis.com>
> Date: Sat, 16 Jun 2012 07:09:27 +0200

> > From: Mike Frysinger <vapier@gentoo.org>
> > Date: Sat, 16 Jun 2012 06:55:49 +0200
> 
> > i vote for deleting all sysdep.h inclusions where the port doesn't have a
> > local sysdep.h.
> 
> Sounds right, except that in some cases (like for cris-desc.c)
> it's the (CGEN) generator templates files that need fixing.

But the failing one was all human-written code.  Fixed thus,
committed.  People, when you edit these things, please
test-build the affected simulators.  It doesn't catch the
weirdest host cases, but it does catch most breakages.

sim/mn10300:

	* interp.c: Include config.h first.  Do not include sysdep.h.

Index: interp.c
===================================================================
RCS file: /cvs/src/src/sim/mn10300/interp.c,v
retrieving revision 1.8
diff -p -u -r1.8 interp.c
--- interp.c	16 Feb 2012 23:17:27 -0000	1.8
+++ interp.c	17 Jun 2012 18:55:44 -0000
@@ -1,10 +1,10 @@
+#include "config.h"
 #include <signal.h>
 
 #include "sim-main.h"
 #include "sim-options.h"
 #include "sim-hw.h"
 
-#include "sysdep.h"
 #include "bfd.h"
 #include "sim-assert.h"
 
brgds, H-P


  reply	other threads:[~2012-06-17 18:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15 18:46 Hans-Peter Nilsson
2012-06-15 18:56 ` Joel Brobecker
2012-06-15 19:15   ` Joel Brobecker
2012-06-15 19:39     ` Pedro Alves
2012-06-15 19:52       ` Joel Brobecker
2012-06-15 21:15         ` Pedro Alves
2012-06-16  4:56           ` Mike Frysinger
2012-06-16  5:09             ` Hans-Peter Nilsson
2012-06-17 18:57               ` Hans-Peter Nilsson [this message]
2012-06-17 23:34             ` Mike Frysinger
2012-06-18 18:39           ` Joel Brobecker
2012-06-15 20:37     ` Hans-Peter Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206171857.q5HIvcPk004487@ignucius.se.axis.com \
    --to=hans-peter.nilsson@axis.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox