From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>,
Joel Brobecker <brobecker@adacore.com>,
"Hans-Peter Nilsson" <hans-peter.nilsson@axis.com>
Subject: Re: build error for mn10300-elf sim with your recent commit
Date: Sun, 17 Jun 2012 23:34:00 -0000 [thread overview]
Message-ID: <201206171933.48621.vapier@gentoo.org> (raw)
In-Reply-To: <201206160055.51737.vapier@gentoo.org>
[-- Attachment #1: Type: Text/Plain, Size: 1394 bytes --]
On Saturday 16 June 2012 00:55:49 Mike Frysinger wrote:
> i vote for deleting all sysdep.h inclusions where the port doesn't have a
> local sysdep.h.
i've committed this to fix moxie build:
2012-06-17 Mike Frysinger <vapier@gentoo.org>
* interp.c: Include config.h first. Also include fcntl.h directly.
--- moxie/interp.c 4 Jan 2012 08:28:21 -0000 1.13
+++ moxie/interp.c 17 Jun 2012 23:32:46 -0000
@@ -17,6 +17,8 @@ GNU General Public License for more deta
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+#include "config.h"
+#include <fcntl.h>
#include <signal.h>
#include <stdlib.h>
#include "sysdep.h"
then i did this for fun:
2012-06-17 Mike Frysinger <vapier@gentoo.org>
* interp.c: Include config.h first. Also include stdlib.h and
string.h so we can drop the sysdep.h include.
--- cr16/interp.c 24 May 2012 16:51:41 -0000 1.9
+++ cr16/interp.c 17 Jun 2012 23:29:35 -0000
@@ -17,8 +17,10 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+#include "config.h"
#include <signal.h>
-#include "sysdep.h"
+#include <stdlib.h>
+#include <string.h>
#include "bfd.h"
#include "gdb/callback.h"
#include "gdb/remote-sim.h"
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-17 23:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 18:46 Hans-Peter Nilsson
2012-06-15 18:56 ` Joel Brobecker
2012-06-15 19:15 ` Joel Brobecker
2012-06-15 19:39 ` Pedro Alves
2012-06-15 19:52 ` Joel Brobecker
2012-06-15 21:15 ` Pedro Alves
2012-06-16 4:56 ` Mike Frysinger
2012-06-16 5:09 ` Hans-Peter Nilsson
2012-06-17 18:57 ` Hans-Peter Nilsson
2012-06-17 23:34 ` Mike Frysinger [this message]
2012-06-18 18:39 ` Joel Brobecker
2012-06-15 20:37 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206171933.48621.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hans-peter.nilsson@axis.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox