From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3102 invoked by alias); 17 Jun 2012 18:57:57 -0000 Received: (qmail 3094 invoked by uid 22791); 17 Jun 2012 18:57:56 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_NO,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 17 Jun 2012 18:57:41 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id E523519DD4; Sun, 17 Jun 2012 20:57:40 +0200 (CEST) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id WjY-83zd9xdp; Sun, 17 Jun 2012 20:57:40 +0200 (CEST) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by anubis.se.axis.com (Postfix) with ESMTP id ADED819D8B; Sun, 17 Jun 2012 20:57:39 +0200 (CEST) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id 72F7434100; Sun, 17 Jun 2012 20:57:39 +0200 (CEST) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id q5HIvdmt004491; Sun, 17 Jun 2012 20:57:39 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id q5HIvcPk004487; Sun, 17 Jun 2012 20:57:38 +0200 Date: Sun, 17 Jun 2012 18:57:00 -0000 Message-Id: <201206171857.q5HIvcPk004487@ignucius.se.axis.com> From: Hans-Peter Nilsson To: gdb-patches@sourceware.org CC: vapier@gentoo.org, palves@redhat.com, brobecker@adacore.com In-reply-to: <201206160509.q5G59RJX004949@ignucius.se.axis.com> (message from Hans-Peter Nilsson on Sat, 16 Jun 2012 07:09:27 +0200) Subject: Re: build error for mn10300-elf sim with your recent commit MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00556.txt.bz2 > From: Hans-Peter Nilsson > Date: Sat, 16 Jun 2012 07:09:27 +0200 > > From: Mike Frysinger > > Date: Sat, 16 Jun 2012 06:55:49 +0200 > > > i vote for deleting all sysdep.h inclusions where the port doesn't have a > > local sysdep.h. > > Sounds right, except that in some cases (like for cris-desc.c) > it's the (CGEN) generator templates files that need fixing. But the failing one was all human-written code. Fixed thus, committed. People, when you edit these things, please test-build the affected simulators. It doesn't catch the weirdest host cases, but it does catch most breakages. sim/mn10300: * interp.c: Include config.h first. Do not include sysdep.h. Index: interp.c =================================================================== RCS file: /cvs/src/src/sim/mn10300/interp.c,v retrieving revision 1.8 diff -p -u -r1.8 interp.c --- interp.c 16 Feb 2012 23:17:27 -0000 1.8 +++ interp.c 17 Jun 2012 18:55:44 -0000 @@ -1,10 +1,10 @@ +#include "config.h" #include #include "sim-main.h" #include "sim-options.h" #include "sim-hw.h" -#include "sysdep.h" #include "bfd.h" #include "sim-assert.h" brgds, H-P