From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [patchv2] Fix Sun compiler compat. for empty structs (PR build/14003)
Date: Wed, 13 Jun 2012 14:47:00 -0000 [thread overview]
Message-ID: <20120613144716.GA18729@adacore.com> (raw)
In-Reply-To: <20120613084834.GA20233@host2.jankratochvil.net>
> I believe in a rule runtime on GNU system should not be negatively affected by
> non-GNU systems defects compatibility.
But I don't understand why you would say that, since it's not a GNU vs
non-GNU. It's a correctness issue. We're just lucky that GCC accepts it.
How many instances of this struct are we talking about? Just a few,
right? So it's just a few wasted bytes... That's now 3 people who
suggested it, I think it's a good compromise.
> I can do so if anybody does not like the #if 0 construct.
Just repeating what I said before: I am OK with that, just not my
prefered solution. At the risk of looking like a despot, I would
not spend too much time arguing about this. This is one of these
issues that is just too minor to be wasting emails and time. Unless
there are real objections, you are the one working on the change,
so go with that you prefer.
--
Joel
next prev parent reply other threads:[~2012-06-13 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 20:48 [patch] " Jan Kratochvil
2012-06-12 21:24 ` Joel Brobecker
2012-06-12 21:52 ` Jan Kratochvil
2012-06-13 6:51 ` [patchv2] " Jan Kratochvil
2012-06-13 8:30 ` Mark Kettenis
2012-06-13 8:49 ` Jan Kratochvil
2012-06-13 14:47 ` Joel Brobecker [this message]
2012-06-13 18:19 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613144716.GA18729@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox