From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21808 invoked by alias); 13 Jun 2012 14:47:49 -0000 Received: (qmail 21797 invoked by uid 22791); 13 Jun 2012 14:47:48 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 14:47:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8223D1C703F; Wed, 13 Jun 2012 10:47:19 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id K1loUrzaFqKT; Wed, 13 Jun 2012 10:47:19 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3BF251C6F47; Wed, 13 Jun 2012 10:47:18 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E9126145616; Wed, 13 Jun 2012 07:47:16 -0700 (PDT) Date: Wed, 13 Jun 2012 14:47:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [patchv2] Fix Sun compiler compat. for empty structs (PR build/14003) Message-ID: <20120613144716.GA18729@adacore.com> References: <20120612204751.GA13700@host2.jankratochvil.net> <20120612212413.GS2687@adacore.com> <20120612215116.GA23941@host2.jankratochvil.net> <20120613065059.GA11317@host2.jankratochvil.net> <201206130830.q5D8UBv8028230@glazunov.sibelius.xs4all.nl> <20120613084834.GA20233@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120613084834.GA20233@host2.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00405.txt.bz2 > I believe in a rule runtime on GNU system should not be negatively affected by > non-GNU systems defects compatibility. But I don't understand why you would say that, since it's not a GNU vs non-GNU. It's a correctness issue. We're just lucky that GCC accepts it. How many instances of this struct are we talking about? Just a few, right? So it's just a few wasted bytes... That's now 3 people who suggested it, I think it's a good compromise. > I can do so if anybody does not like the #if 0 construct. Just repeating what I said before: I am OK with that, just not my prefered solution. At the risk of looking like a despot, I would not spend too much time arguing about this. This is one of these issues that is just too minor to be wasting emails and time. Unless there are real objections, you are the one working on the change, so go with that you prefer. -- Joel