Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [patchv2] Fix Sun compiler compat. for empty structs (PR build/14003)
Date: Wed, 13 Jun 2012 08:49:00 -0000	[thread overview]
Message-ID: <20120613084834.GA20233@host2.jankratochvil.net> (raw)
In-Reply-To: <201206130830.q5D8UBv8028230@glazunov.sibelius.xs4all.nl>

On Wed, 13 Jun 2012 10:30:11 +0200, Mark Kettenis wrote:
> At the risk of turning this into a bikeshed:
> 
> Isn't it simpler to just put a dummy member inside that struct, and forget
> about the #if 0 stuff?

I believe in a rule runtime on GNU system should not be negatively affected by
non-GNU systems defects compatibility.

The really correct way in this case is to autoconf compiler support for empty
structs and put there that dummy member but only on those non-GNU systems.

I can do so if anybody does not like the #if 0 construct.


Thanks,
Jan


  reply	other threads:[~2012-06-13  8:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 20:48 [patch] " Jan Kratochvil
2012-06-12 21:24 ` Joel Brobecker
2012-06-12 21:52   ` Jan Kratochvil
2012-06-13  6:51     ` [patchv2] " Jan Kratochvil
2012-06-13  8:30       ` Mark Kettenis
2012-06-13  8:49         ` Jan Kratochvil [this message]
2012-06-13 14:47           ` Joel Brobecker
2012-06-13 18:19             ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120613084834.GA20233@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox