From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13809 invoked by alias); 13 Jun 2012 08:49:16 -0000 Received: (qmail 13800 invoked by uid 22791); 13 Jun 2012 08:49:15 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 08:49:02 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5D8mfUd020604 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jun 2012 04:48:41 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5D8mZSS019285 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 13 Jun 2012 04:48:40 -0400 Date: Wed, 13 Jun 2012 08:49:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: [patchv2] Fix Sun compiler compat. for empty structs (PR build/14003) Message-ID: <20120613084834.GA20233@host2.jankratochvil.net> References: <20120612204751.GA13700@host2.jankratochvil.net> <20120612212413.GS2687@adacore.com> <20120612215116.GA23941@host2.jankratochvil.net> <20120613065059.GA11317@host2.jankratochvil.net> <201206130830.q5D8UBv8028230@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201206130830.q5D8UBv8028230@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00390.txt.bz2 On Wed, 13 Jun 2012 10:30:11 +0200, Mark Kettenis wrote: > At the risk of turning this into a bikeshed: > > Isn't it simpler to just put a dummy member inside that struct, and forget > about the #if 0 stuff? I believe in a rule runtime on GNU system should not be negatively affected by non-GNU systems defects compatibility. The really correct way in this case is to autoconf compiler support for empty structs and put there that dummy member but only on those non-GNU systems. I can do so if anybody does not like the #if 0 construct. Thanks, Jan