[gdb commit] [RFC patch] non-release srctrees: --enable-targets=all & 64bit & -lmcheck

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Fri, 01 Jun 2012 18:11:43 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> -lmcheck is cheap enough to never be noticed and it also finds checked in
> Jan> regressions:
> 
> I'm in favor of this part.  Could you separate out just the gdb part and
> put it in?

Checked in only the gdb/ part.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2012-06/msg00005.html

--- src/gdb/ChangeLog	2012/06/01 16:37:56	1.14309
+++ src/gdb/ChangeLog	2012/06/01 18:20:16	1.14310
@@ -1,3 +1,11 @@
+2012-06-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* configure.ac (development): Define new variable.
+	Call AC_CHECK_LIB for mcheck if $development.
+	(ERROR_ON_WARNING): Enable it by default only if $development.
+	* config.in: Regenerate.
+	* configure: Regenerate.
+
 2012-06-01  Siddhesh Poyarekar  <siddhesh@redhat.com>
 
 	* target.c (target_read_memory): Make LEN argument as size_t.
--- src/gdb/config.in	2012/05/11 18:20:26	1.143
+++ src/gdb/config.in	2012/06/01 18:20:18	1.144
--- src/gdb/configure	2012/05/20 20:35:18	1.365
+++ src/gdb/configure	2012/06/01 18:20:18	1.366
--- src/gdb/configure.ac	2012/05/20 20:35:19	1.176
+++ src/gdb/configure.ac	2012/06/01 18:20:18	1.177
@@ -18,6 +18,11 @@
 
 dnl Process this file with autoconf to produce a configure script.
 
+dnl Provide more thorough testing by -lmcheck.
+dnl Set it to 'true' for development snapshots, 'false' for releases or
+dnl pre-releases.
+development=true
+
 AC_PREREQ(2.59)dnl
 AC_INIT(main.c)
 AC_CONFIG_HEADER(config.h:config.in)
@@ -640,6 +645,11 @@
 AC_SUBST(READLINE_CFLAGS)
 AC_SUBST(READLINE_TEXI_INCFLAG)
 
+dnl -lmcheck provides cheap enough memory mangling for debugging purposes.
+if $development; then
+  AC_CHECK_LIB(mcheck, main)
+fi
+
 # Generate jit-reader.h
 
 # This is typedeffed to GDB_CORE_ADDR in jit-reader.h
@@ -1822,8 +1832,8 @@
      *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;;
    esac])
 
-# Enable -Werror by default when using gcc
-if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
+# Enable -Werror by default when using gcc.  Turn it off for releases.
+if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" && $development; then
     ERROR_ON_WARNING=yes
 fi