Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: binutils@sourceware.org
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC patch] non-release srctrees: --enable-targets=all & 64bit & -lmcheck
Date: Sun, 20 May 2012 14:10:00 -0000	[thread overview]
Message-ID: <20120520141028.GA8717@host2.jankratochvil.net> (raw)
In-Reply-To: <20120520135915.GB3285@bubble.grove.modra.org>

On Sun, 20 May 2012 15:59:16 +0200, Alan Modra wrote:
> > --enable-64-bit-bfd is required for full --enable-targets=all.
> 
> Always building with a 64-bit bfd hides another class of bug.

Yes, I run nightly build without --enable-64-bit-bfd here to test such bugs.

The goal of my proposal was to catch most of the bugs already by the
submitter.  We cannot want from all submitters to test too many combinations
(I do 3*17 = 46 runs; it equals a bit less due to some limitations).
So we should choose some best single catch-almost-all configuration.

While there are countercases I believe >90% of bugs get more caught by
--enable-targets=all --enable-64-bit-bfd than by any other settings.

After I know submitters run --enable-targets=all themselves I probably start
also runs without --enable-targets=all to test the other case, also I would
start new runs running -lmcheck.


> I'm not in favour of this patch.  Yes, it may help first-time
> contributors in testing their patches, but means yet another change in
> configure options for anyone past that stage.

I find the largest disadvantage that after switching to development=false for
the release the srctree becomes "untested".  Even -lmcheck may hide some bugs.
But there is also the pre-release gdb-x.y.90.z phase to catch those bugs.


I just find current regressions happenning almost daily without this patch to
be too boring.


Thanks,
Jan


  reply	other threads:[~2012-05-20 14:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 21:14 Jan Kratochvil
2012-05-20 13:59 ` Alan Modra
2012-05-20 14:10   ` Jan Kratochvil [this message]
2012-06-01 16:12 ` Tom Tromey
2012-06-01 18:21   ` [gdb commit] " Jan Kratochvil
2012-06-06 18:06     ` [commit#2] " Jan Kratochvil
2012-07-20 14:01     ` [gdb commit] " H.J. Lu
2012-07-23 14:43       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120520141028.GA8717@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox