Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [RFC patch] non-release srctrees: --enable-targets=all & 64bit & -lmcheck
Date: Sun, 20 May 2012 13:59:00 -0000	[thread overview]
Message-ID: <20120520135915.GB3285@bubble.grove.modra.org> (raw)
In-Reply-To: <20120518211410.GA32107@host2.jankratochvil.net>

On Fri, May 18, 2012 at 11:14:10PM +0200, Jan Kratochvil wrote:
> --enable-targets=all commonly discovers checked in regressions:
> 	http://sourceware.org/ml/binutils/2012-05/msg00271.html

Not in this particular case.  I built binutils for native x86_64-linux
--enable-targes=all.  In fact, I also built 115 different cross
targets (needed to test gas reasonably well).  I've now added one more
target. :)

> 	http://sourceware.org/ml/gdb-patches/2012-05/msg00548.html
> 	http://sourceware.org/ml/gdb-patches/2012-05/msg00003.html
> 	http://sourceware.org/ml/gdb-patches/2012-03/msg00279.html
> 	http://sourceware.org/ml/gdb-patches/2011-03/msg00600.html
> 	(many more, I did not search too thoroughly)

There are cases where building with --enable-targets=all hides bugs,
for example
http://sourceware.org/ml/binutils/2012-05/msg00219.html

> --enable-64-bit-bfd is required for full --enable-targets=all.

Always building with a 64-bit bfd hides another class of bug.

I'm not in favour of this patch.  Yes, it may help first-time
contributors in testing their patches, but means yet another change in
configure options for anyone past that stage.  (Hey, I tested my patch
on 32-bit i686-linux and 64-bit x86_64-linux and you say it's not
64-bit clean??)

-- 
Alan Modra
Australia Development Lab, IBM


  reply	other threads:[~2012-05-20 13:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 21:14 Jan Kratochvil
2012-05-20 13:59 ` Alan Modra [this message]
2012-05-20 14:10   ` Jan Kratochvil
2012-06-01 16:12 ` Tom Tromey
2012-06-01 18:21   ` [gdb commit] " Jan Kratochvil
2012-06-06 18:06     ` [commit#2] " Jan Kratochvil
2012-07-20 14:01     ` [gdb commit] " H.J. Lu
2012-07-23 14:43       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120520135915.GB3285@bubble.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox