From: Joel Brobecker <brobecker@adacore.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gdb-patches@sourceware.org, Kevin Buettner <kevinb@redhat.com>
Subject: Re: [SH] gdb.arch/gdb1291.exp, gdb.arch/gdb1431.exp
Date: Wed, 16 May 2012 14:37:00 -0000 [thread overview]
Message-ID: <20120516143713.GA26164@adacore.com> (raw)
In-Reply-To: <87fwcze2w7.fsf@schwinge.name>
Really sorry for the delay...
> Exactly the same for gdb.arch/gdb1431.exp: their source files
> (gdb.arch/gdb1291.s, gdb.arch/gdb1431.s) are identical, and I first
> propose to get rid of one of them:
>
> gdb/testsuite/
>
> * gdb.arch/gdb1431.s: Remove file.
> * gdb.arch/gdb1431.exp (srcfile): Refer to gdb1291.s.
No one objected to this, it seems. I verified that you still
generate one executable per testcase, which is what we want.
So no objection from me.
> Next, for the linking error, the problem is that global symbols (such as
> printf) are specified with a leading underscore, which is correct for
> sh-elf, but not for sh-linux-gnu. Relying on GCC's
> __USER_LABEL_PREFIX__, I propose the following:
I would rather not rely on GCC-isms for this. You should take a look
at how we deal with this in other testcases. See
gdb_target_symbol_prefix_flags in testsuite/lib/gdb.exp, and
how it is used in some of the Windows targets.
--
Joel
prev parent reply other threads:[~2012-05-16 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 15:47 Thomas Schwinge
2012-03-28 4:52 ` Kevin Buettner
2012-03-30 17:58 ` Thomas Schwinge
2012-04-16 7:54 ` Thomas Schwinge
2012-05-09 2:27 ` Thomas Schwinge
2012-05-16 14:11 ` Thomas Schwinge
2012-05-16 14:37 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516143713.GA26164@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox