From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29399 invoked by alias); 16 May 2012 14:37:39 -0000 Received: (qmail 29279 invoked by uid 22791); 16 May 2012 14:37:38 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 May 2012 14:37:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8CF761C6F7A; Wed, 16 May 2012 10:37:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jctqr0AYcU4l; Wed, 16 May 2012 10:37:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B51001C6F8E; Wed, 16 May 2012 10:37:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 85076145616; Wed, 16 May 2012 07:37:13 -0700 (PDT) Date: Wed, 16 May 2012 14:37:00 -0000 From: Joel Brobecker To: Thomas Schwinge Cc: gdb-patches@sourceware.org, Kevin Buettner Subject: Re: [SH] gdb.arch/gdb1291.exp, gdb.arch/gdb1431.exp Message-ID: <20120516143713.GA26164@adacore.com> References: <87fwcze2w7.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fwcze2w7.fsf@schwinge.name> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00604.txt.bz2 Really sorry for the delay... > Exactly the same for gdb.arch/gdb1431.exp: their source files > (gdb.arch/gdb1291.s, gdb.arch/gdb1431.s) are identical, and I first > propose to get rid of one of them: > > gdb/testsuite/ > > * gdb.arch/gdb1431.s: Remove file. > * gdb.arch/gdb1431.exp (srcfile): Refer to gdb1291.s. No one objected to this, it seems. I verified that you still generate one executable per testcase, which is what we want. So no objection from me. > Next, for the linking error, the problem is that global symbols (such as > printf) are specified with a leading underscore, which is correct for > sh-elf, but not for sh-linux-gnu. Relying on GCC's > __USER_LABEL_PREFIX__, I propose the following: I would rather not rely on GCC-isms for this. You should take a look at how we deal with this in other testcases. See gdb_target_symbol_prefix_flags in testsuite/lib/gdb.exp, and how it is used in some of the Windows targets. -- Joel