From: Thomas Schwinge <thomas@codesourcery.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [SH] gdb.arch/gdb1291.exp, gdb.arch/gdb1431.exp
Date: Fri, 30 Mar 2012 17:58:00 -0000 [thread overview]
Message-ID: <87d37uas4x.fsf@schwinge.name> (raw)
In-Reply-To: <20120327215213.232d5857@mesquite.lan>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
Hi!
On Tue, 27 Mar 2012 21:52:13 -0700, Kevin Buettner <kevinb@redhat.com> wrote:
> On Fri, 23 Mar 2012 16:46:32 +0100
> Thomas Schwinge <thomas@codesourcery.com> wrote:
>
> > Exactly the same for gdb.arch/gdb1431.exp: their source files
> > (gdb.arch/gdb1291.s, gdb.arch/gdb1431.s) are identical, and I first
> > propose to get rid of one of them:
> >
> > gdb/testsuite/
> >
> > * gdb.arch/gdb1431.s: Remove file.
> > * gdb.arch/gdb1431.exp (srcfile): Refer to gdb1291.s.
>
> I don't know enough about the tests in question to say whether
> this is a good approach or not.
Apparently nobody else does, too. ;-)
> Is there a chance that someone
> will want to tweak the code for one of the test cases without
> also having to tweak the other?
No, given what they're testing, I don't expect this would ever happen.
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2012-03-30 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 15:47 Thomas Schwinge
2012-03-28 4:52 ` Kevin Buettner
2012-03-30 17:58 ` Thomas Schwinge [this message]
2012-04-16 7:54 ` Thomas Schwinge
2012-05-09 2:27 ` Thomas Schwinge
2012-05-16 14:11 ` Thomas Schwinge
2012-05-16 14:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d37uas4x.fsf@schwinge.name \
--to=thomas@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox