From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Stan Shebs <stanshebs@earthlink.net>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: [commit] testsuite: gdb.base/dprintf.exp PR 12649 race [Re: [PATCH v2] dynamic printf]
Date: Tue, 15 May 2012 13:10:00 -0000 [thread overview]
Message-ID: <20120515130954.GA16932@host2.jankratochvil.net> (raw)
In-Reply-To: <4FB12A8E.7040905@earthlink.net>
On Mon, 14 May 2012 17:53:50 +0200, Stan Shebs wrote:
> Thanks for the feedback! Here's what I committed.
seeing racy results
+Running gdb/testsuite/gdb.base/dprintf.exp ...
+FAIL: gdb.base/dprintf.exp: dprintf
+PASS: gdb.base/dprintf.exp: dprintf foo
+PASS: gdb.base/dprintf.exp: dprintf 29
+ERROR: breakpoints not deleted
+UNRESOLVED: gdb.base/dprintf.exp: dprintf foo,"At foo entry\n"
with the read1 reproducer from
http://sourceware.org/bugzilla/show_bug.cgi?id=12649
it shows:
(gdb) run ^M
Starting program: /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.base/dprintf ^M
dprintf^M
warning: Skipping deprecated .gdb_index section in /usr/lib/debug/lib64/ld-2.15.so.debug, pass --use-deprecated-index-sections to use them anyway^M
^M
Breakpoint 1, main (argc=1, argv=0x7fffffffdb98) at ./gdb.base/dprintf.c:33^M
33 int loc = 1234;^M
(gdb) FAIL: gdb.base/dprintf.exp: dprintf
Checked in the fix.
Regards,
Jan
http://sourceware.org/ml/gdb-cvs/2012-05/msg00107.html
--- src/gdb/testsuite/ChangeLog 2012/05/14 20:33:16 1.3189
+++ src/gdb/testsuite/ChangeLog 2012/05/15 13:08:57 1.3190
@@ -1,3 +1,8 @@
+2012-05-15 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ PR testsuite/12649
+ * gdb.base/dprintf.exp: Replace gdb_run_cmd by runto main.
+
2012-05-14 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.base/stap-probe.exp (stap_test): Remove calls to
--- src/gdb/testsuite/gdb.base/dprintf.exp 2012/05/14 15:38:41 1.1
+++ src/gdb/testsuite/gdb.base/dprintf.exp 2012/05/15 13:08:58 1.2
@@ -24,7 +24,9 @@
set dp_location1 [gdb_get_line_number "set dprintf 1 here"]
gdb_breakpoint "main"
-gdb_run_cmd
+if ![runto main] {
+ return -1
+}
gdb_test "dprintf" "Format string required"
next prev parent reply other threads:[~2012-05-15 13:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 6:27 [PATCH v2] dynamic printf Stan Shebs
2012-05-08 7:50 ` Yao Qi
2012-05-14 15:54 ` Stan Shebs
2012-05-15 4:10 ` [commit] Fix spu-tdep.c build regression [Re: [PATCH v2] dynamic printf] Jan Kratochvil
2012-05-15 10:24 ` Jim Meyering
2012-05-15 13:10 ` Jan Kratochvil [this message]
2012-05-15 13:34 ` [commit] testsuite: gdb.base/dprintf.exp PR 12649 race " Joel Brobecker
2012-05-15 13:37 ` [commit#2] " Jan Kratochvil
2012-05-16 20:17 ` [PATCH v2] dynamic printf Tom Tromey
2012-05-16 20:46 ` Stan Shebs
2012-05-16 20:52 ` Pedro Alves
2012-05-16 22:25 ` Stan Shebs
2012-05-17 1:56 ` Tom Tromey
2012-05-18 15:38 ` Pedro Alves
2012-05-16 20:53 ` Pedro Alves
2012-05-16 21:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515130954.GA16932@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stanshebs@earthlink.net \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox