From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20605 invoked by alias); 15 May 2012 13:10:23 -0000 Received: (qmail 20567 invoked by uid 22791); 15 May 2012 13:10:21 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 13:10:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4FD9w5H020921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 May 2012 09:09:58 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4FD9se2001251 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 15 May 2012 09:09:57 -0400 Date: Tue, 15 May 2012 13:10:00 -0000 From: Jan Kratochvil To: Stan Shebs Cc: Yao Qi , gdb-patches@sourceware.org Subject: [commit] testsuite: gdb.base/dprintf.exp PR 12649 race [Re: [PATCH v2] dynamic printf] Message-ID: <20120515130954.GA16932@host2.jankratochvil.net> References: <4FA8BC97.2000801@earthlink.net> <4FA8D049.109@codesourcery.com> <4FB12A8E.7040905@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FB12A8E.7040905@earthlink.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00563.txt.bz2 On Mon, 14 May 2012 17:53:50 +0200, Stan Shebs wrote: > Thanks for the feedback! Here's what I committed. seeing racy results +Running gdb/testsuite/gdb.base/dprintf.exp ... +FAIL: gdb.base/dprintf.exp: dprintf +PASS: gdb.base/dprintf.exp: dprintf foo +PASS: gdb.base/dprintf.exp: dprintf 29 +ERROR: breakpoints not deleted +UNRESOLVED: gdb.base/dprintf.exp: dprintf foo,"At foo entry\n" with the read1 reproducer from http://sourceware.org/bugzilla/show_bug.cgi?id=12649 it shows: (gdb) run ^M Starting program: /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.base/dprintf ^M dprintf^M warning: Skipping deprecated .gdb_index section in /usr/lib/debug/lib64/ld-2.15.so.debug, pass --use-deprecated-index-sections to use them anyway^M ^M Breakpoint 1, main (argc=1, argv=0x7fffffffdb98) at ./gdb.base/dprintf.c:33^M 33 int loc = 1234;^M (gdb) FAIL: gdb.base/dprintf.exp: dprintf Checked in the fix. Regards, Jan http://sourceware.org/ml/gdb-cvs/2012-05/msg00107.html --- src/gdb/testsuite/ChangeLog 2012/05/14 20:33:16 1.3189 +++ src/gdb/testsuite/ChangeLog 2012/05/15 13:08:57 1.3190 @@ -1,3 +1,8 @@ +2012-05-15 Jan Kratochvil + + PR testsuite/12649 + * gdb.base/dprintf.exp: Replace gdb_run_cmd by runto main. + 2012-05-14 Sergio Durigan Junior * gdb.base/stap-probe.exp (stap_test): Remove calls to --- src/gdb/testsuite/gdb.base/dprintf.exp 2012/05/14 15:38:41 1.1 +++ src/gdb/testsuite/gdb.base/dprintf.exp 2012/05/15 13:08:58 1.2 @@ -24,7 +24,9 @@ set dp_location1 [gdb_get_line_number "set dprintf 1 here"] gdb_breakpoint "main" -gdb_run_cmd +if ![runto main] { + return -1 +} gdb_test "dprintf" "Format string required"