Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Stan Shebs <stanshebs@earthlink.net>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: [commit] Fix spu-tdep.c build regression  [Re: [PATCH v2] dynamic printf]
Date: Tue, 15 May 2012 04:10:00 -0000	[thread overview]
Message-ID: <20120515041015.GA28656@host2.jankratochvil.net> (raw)
In-Reply-To: <4FB12A8E.7040905@earthlink.net>

On Mon, 14 May 2012 17:53:50 +0200, Stan Shebs wrote:
> Thanks for the feedback!  Here's what I committed.

with --enable-targets=all:

spu-tdep.c: In function ‘spu_catch_start’:
spu-tdep.c:1950:8: error: incompatible type for argument 10 of ‘create_breakpoint’
In file included from inferior.h:37:0,
                 from spu-tdep.c:36:
breakpoint.h:1220:12: note: expected ‘enum auto_boolean’ but argument is of type ‘struct breakpoint_ops *’
spu-tdep.c:1950:8: error: too few arguments to function ‘create_breakpoint’
In file included from inferior.h:37:0,
                 from spu-tdep.c:36:
breakpoint.h:1220:12: note: declared here


BTW sourceware GIT still displays you as:
	Author: Stan Shebs <shebs@apple.com>


Regards,
Jan


http://sourceware.org/ml/gdb-cvs/2012-05/msg00105.html

--- src/gdb/ChangeLog	2012/05/14 18:56:39	1.14249
+++ src/gdb/ChangeLog	2012/05/15 04:08:44	1.14250
@@ -1,3 +1,8 @@
+2012-05-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* spu-tdep.c (spu_catch_start): Update create_breakpoint caller
+	parameters.
+
 2012-05-14  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* amd64-tdep.c: Include features/i386/x32.c and
--- src/gdb/spu-tdep.c	2012/03/13 13:30:42	1.78
+++ src/gdb/spu-tdep.c	2012/05/15 04:08:47	1.79
@@ -1942,6 +1942,7 @@
   xsnprintf (buf, sizeof buf, "*%s", core_addr_to_string (pc));
   create_breakpoint (get_objfile_arch (objfile), buf /* arg */,
 		     NULL /* cond_string */, -1 /* thread */,
+		     NULL /* extra_string */,
 		     0 /* parse_condition_and_thread */, 1 /* tempflag */,
 		     bp_breakpoint /* type_wanted */,
 		     0 /* ignore_count */,


  reply	other threads:[~2012-05-15  4:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08  6:27 [PATCH v2] dynamic printf Stan Shebs
2012-05-08  7:50 ` Yao Qi
2012-05-14 15:54   ` Stan Shebs
2012-05-15  4:10     ` Jan Kratochvil [this message]
2012-05-15 10:24       ` [commit] Fix spu-tdep.c build regression [Re: [PATCH v2] dynamic printf] Jim Meyering
2012-05-15 13:10     ` [commit] testsuite: gdb.base/dprintf.exp PR 12649 race " Jan Kratochvil
2012-05-15 13:34       ` Joel Brobecker
2012-05-15 13:37         ` [commit#2] " Jan Kratochvil
2012-05-16 20:17     ` [PATCH v2] dynamic printf Tom Tromey
2012-05-16 20:46       ` Stan Shebs
2012-05-16 20:52         ` Pedro Alves
2012-05-16 22:25           ` Stan Shebs
2012-05-17  1:56             ` Tom Tromey
2012-05-18 15:38               ` Pedro Alves
2012-05-16 20:53         ` Pedro Alves
2012-05-16 21:06         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120515041015.GA28656@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=stanshebs@earthlink.net \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox