From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2818 invoked by alias); 15 May 2012 04:10:50 -0000 Received: (qmail 2805 invoked by uid 22791); 15 May 2012 04:10:48 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_XS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 04:10:25 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4F4AKTC018098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 May 2012 00:10:20 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4F4AGXx007015 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 15 May 2012 00:10:19 -0400 Date: Tue, 15 May 2012 04:10:00 -0000 From: Jan Kratochvil To: Stan Shebs Cc: Yao Qi , gdb-patches@sourceware.org Subject: [commit] Fix spu-tdep.c build regression [Re: [PATCH v2] dynamic printf] Message-ID: <20120515041015.GA28656@host2.jankratochvil.net> References: <4FA8BC97.2000801@earthlink.net> <4FA8D049.109@codesourcery.com> <4FB12A8E.7040905@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <4FB12A8E.7040905@earthlink.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00548.txt.bz2 On Mon, 14 May 2012 17:53:50 +0200, Stan Shebs wrote: > Thanks for the feedback! Here's what I committed. with --enable-targets=all: spu-tdep.c: In function ‘spu_catch_start’: spu-tdep.c:1950:8: error: incompatible type for argument 10 of ‘create_breakpoint’ In file included from inferior.h:37:0, from spu-tdep.c:36: breakpoint.h:1220:12: note: expected ‘enum auto_boolean’ but argument is of type ‘struct breakpoint_ops *’ spu-tdep.c:1950:8: error: too few arguments to function ‘create_breakpoint’ In file included from inferior.h:37:0, from spu-tdep.c:36: breakpoint.h:1220:12: note: declared here BTW sourceware GIT still displays you as: Author: Stan Shebs Regards, Jan http://sourceware.org/ml/gdb-cvs/2012-05/msg00105.html --- src/gdb/ChangeLog 2012/05/14 18:56:39 1.14249 +++ src/gdb/ChangeLog 2012/05/15 04:08:44 1.14250 @@ -1,3 +1,8 @@ +2012-05-15 Jan Kratochvil + + * spu-tdep.c (spu_catch_start): Update create_breakpoint caller + parameters. + 2012-05-14 H.J. Lu * amd64-tdep.c: Include features/i386/x32.c and --- src/gdb/spu-tdep.c 2012/03/13 13:30:42 1.78 +++ src/gdb/spu-tdep.c 2012/05/15 04:08:47 1.79 @@ -1942,6 +1942,7 @@ xsnprintf (buf, sizeof buf, "*%s", core_addr_to_string (pc)); create_breakpoint (get_objfile_arch (objfile), buf /* arg */, NULL /* cond_string */, -1 /* thread */, + NULL /* extra_string */, 0 /* parse_condition_and_thread */, 1 /* tempflag */, bp_breakpoint /* type_wanted */, 0 /* ignore_count */,