Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit 1/3] Import gnulib's update-copyright script
Date: Wed, 18 Apr 2012 14:37:00 -0000	[thread overview]
Message-ID: <20120418143606.GA2852@adacore.com> (raw)
In-Reply-To: <4F8EB486.5020308@redhat.com>

> > gdb/ChangeLog:
> > 
> >         * gnulib/extra/update-copyright: New file, imported from gnulib.
> 
> 
> It looks like this file was simply copied over instead of imported with
> gnulib-tool?  If I reimport the gnulib/ directory from scratch, we lose it:

I am pretty sure I pulled it using gnulib tool... But I think
I then just selectively checked the script in only, to avoid
bringing in more changes than necessary.

This business of maintaining our gnulib import is getting a little
silly, because we cannot determine for sure how people might have
imported stuff. Perhaps we should just go ahead with the script
I wrote to import/update our gnulib import, and make sure people
use that? It might not be the perfect way of doing it, but at least
it would be consistent.

> If I pull the "update-copyright" gnulib module in addition, with:
[...]
> then we get it back, but, we get an older 2010 version, thus we end up
> with a non-empty diff, see below.

Do you know why? I thought that it would just import whatever version
you have checked out. Did you do the import using the exact same
version that you used during the last import?

When I did this, I just pulled the latest gnulib from git, and then
called gnulib tool. That's why I am a little confused by you saying
that you'll update gnulib using gnulib-tool.

> It doesn't look like we miss anything important for us.  I think I'll
> apply this,

We'll need the latest version by the end of the year. There are two
things that it brings which we use: warnings when an FSF copyright
isn't found, and also merging all copyright years together into
one single range.

> Okay in principle?

Sure! I think you know how to use gnulib way better than I do.

-- 
Joel


  reply	other threads:[~2012-04-18 14:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04  8:20 New procedure for updating copyright years Joel Brobecker
2012-01-04  8:20 ` [commit 1/3] Import gnulib's update-copyright script Joel Brobecker
2012-04-18 12:41   ` Pedro Alves
2012-04-18 14:37     ` Joel Brobecker [this message]
2012-04-18 14:52       ` Pedro Alves
2012-04-18 14:54         ` Joel Brobecker
2012-04-18 15:10           ` Pedro Alves
2012-04-18 15:12           ` Tom Tromey
2012-04-18 20:52     ` Import gnulib's update-copyright whole module Pedro Alves
2012-01-04  8:20 ` [commit 2/3] use gnulib's update-copyright script to update copyright years Joel Brobecker
2012-01-04  8:20 ` [RFA/doco 3/3] Document new procedure for updating " Joel Brobecker
2012-01-04 18:24   ` Eli Zaretskii
2012-01-05  3:34     ` Joel Brobecker
2012-01-05  5:44       ` Eli Zaretskii
2012-01-05  9:42         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418143606.GA2852@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox