From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: New procedure for updating copyright years...
Date: Wed, 04 Jan 2012 08:20:00 -0000 [thread overview]
Message-ID: <1325665146-31682-1-git-send-email-brobecker@adacore.com> (raw)
Hello,
this patch series enhanced our procedures for updating the copyright
years by switching away from an emacs lisp program to a script that's
part of gnulib.
There are several parts to this series:
1. Importing the update-copyright script from gnulib
2. Write a new script that uses it. Since I had never used it before,
I spent a lot of time double-checking the output.
gnulib's update-copyright script is more general than the
emacs-based approach, and it allows us to lift the limitation
about several categories of files that previously had to be updated
by hand. It is also worth mentioning that update-copyright gets
the job done in 2 seconds where the emacs would take, IIRC, a good
10-15 minutes.
update-copyright, however, is a little more sensitive to incorrect
formatting of the copyright notice. As a result, it failed to
find the copyright notice in several files.
But the good news is that it does generate a warning when not finding
the copyright notice in a file. So I enhance our new script to catch
them and process them. For each file that that update-copyright
cannot update, I perform a crude sanity check, and let the warning
through if there is any chance that the file might have, in fact,
a copyright notice.
The script does not let through warning about files where the word
"Copyright" does not appear within the first 50 lines (arbitrary
but seemed like a good number), because there are a LOT (and I mean
A LOT) of those, and so these warnings would drown the rest. We
should probably fix those, but this is not the job of the guy
simply updating the existing copyright notices.
Finally, I should say that the new script was written in Python,
compatible with Python 2.6 and 2.7 at least. This is simply because
it was so much harder for me to write the same sanity checks in
bourne shell.
3. The last patch updates our documentation.
next reply other threads:[~2012-01-04 8:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 8:20 Joel Brobecker [this message]
2012-01-04 8:20 ` [commit 1/3] Import gnulib's update-copyright script Joel Brobecker
2012-04-18 12:41 ` Pedro Alves
2012-04-18 14:37 ` Joel Brobecker
2012-04-18 14:52 ` Pedro Alves
2012-04-18 14:54 ` Joel Brobecker
2012-04-18 15:10 ` Pedro Alves
2012-04-18 15:12 ` Tom Tromey
2012-04-18 20:52 ` Import gnulib's update-copyright whole module Pedro Alves
2012-01-04 8:20 ` [RFA/doco 3/3] Document new procedure for updating copyright years Joel Brobecker
2012-01-04 18:24 ` Eli Zaretskii
2012-01-05 3:34 ` Joel Brobecker
2012-01-05 5:44 ` Eli Zaretskii
2012-01-05 9:42 ` Joel Brobecker
2012-01-04 8:20 ` [commit 2/3] use gnulib's update-copyright script to update " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325665146-31682-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox