From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2220 invoked by alias); 18 Apr 2012 14:36:36 -0000 Received: (qmail 2126 invoked by uid 22791); 18 Apr 2012 14:36:34 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 14:36:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A58571C6C95; Wed, 18 Apr 2012 10:36:15 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6RJ3PuPUqCuM; Wed, 18 Apr 2012 10:36:15 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6BB501C6902; Wed, 18 Apr 2012 10:36:15 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6DC12145616; Wed, 18 Apr 2012 07:36:06 -0700 (PDT) Date: Wed, 18 Apr 2012 14:37:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [commit 1/3] Import gnulib's update-copyright script Message-ID: <20120418143606.GA2852@adacore.com> References: <1325665146-31682-1-git-send-email-brobecker@adacore.com> <1325665146-31682-2-git-send-email-brobecker@adacore.com> <4F8EB486.5020308@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F8EB486.5020308@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00575.txt.bz2 > > gdb/ChangeLog: > > > > * gnulib/extra/update-copyright: New file, imported from gnulib. > > > It looks like this file was simply copied over instead of imported with > gnulib-tool? If I reimport the gnulib/ directory from scratch, we lose it: I am pretty sure I pulled it using gnulib tool... But I think I then just selectively checked the script in only, to avoid bringing in more changes than necessary. This business of maintaining our gnulib import is getting a little silly, because we cannot determine for sure how people might have imported stuff. Perhaps we should just go ahead with the script I wrote to import/update our gnulib import, and make sure people use that? It might not be the perfect way of doing it, but at least it would be consistent. > If I pull the "update-copyright" gnulib module in addition, with: [...] > then we get it back, but, we get an older 2010 version, thus we end up > with a non-empty diff, see below. Do you know why? I thought that it would just import whatever version you have checked out. Did you do the import using the exact same version that you used during the last import? When I did this, I just pulled the latest gnulib from git, and then called gnulib tool. That's why I am a little confused by you saying that you'll update gnulib using gnulib-tool. > It doesn't look like we miss anything important for us. I think I'll > apply this, We'll need the latest version by the end of the year. There are two things that it brings which we use: warnings when an FSF copyright isn't found, and also merging all copyright years together into one single range. > Okay in principle? Sure! I think you know how to use gnulib way better than I do. -- Joel