From: Joel Brobecker <brobecker@adacore.com>
To: Chris January <chris.january@allinea.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] AIX: Add another way of setting up the frame pointer to skip_prologue
Date: Tue, 13 Mar 2012 16:50:00 -0000 [thread overview]
Message-ID: <20120313164958.GR2853@adacore.com> (raw)
In-Reply-To: <1331651889.2755.4.camel@gumtree>
Re:
2012-03-08 Chris January <chris.january@allinea.com>
* rs6000-tdep.c (skip_prologue): Support the oril r29, r1, 0x0
instruction.
> > > > Same comments as before: Looks good, but has it been validated against
> > > > the testsuite?
> > >
> > > No, I have not got the test suite working reliably on AIX yet.
> >
> > If you have a Linux PowerPC box available, you could run the testsuite
> > there to check for regressions.
>
> I did just that, and there were no regressions.
Thanks, Chris. I checked the patch in for you.
Have we started the process for giving you write priviledges so
that you can commit the patches yourself?
PS: Does your mailer wrap long lines? If that's the case, can you send
patches in attachment instead? I couldn't get this patch to apply
even after fixing an obvious long-line automatic-wrap-around. So
I applied it by hand, and verified that the file still compiled.
--
Joel
prev parent reply other threads:[~2012-03-13 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 14:40 Chris January
2012-03-09 19:48 ` Joel Brobecker
2012-03-12 13:14 ` Chris January
2012-03-12 13:43 ` Mark Kettenis
2012-03-13 15:18 ` Chris January
2012-03-13 16:50 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313164958.GR2853@adacore.com \
--to=brobecker@adacore.com \
--cc=chris.january@allinea.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox