Re: [PATCH] AIX: Add another way of setting up the frame pointer to skip_prologue

[Chris January <chris.january@allinea.com>]

On Fri, 2012-03-09 at 11:48 -0800, Joel Brobecker wrote:
> Chris,

> Same comments as before: Looks good, but has it been validated against
> the testsuite?

No, I have not got the test suite working reliably on AIX yet.

> I am just going to suggest one tiny change, which is a bit of a nitpick,
> but I think makes the code relatively consistent:

> I would put the comment outside of the closing parens. I know we do
> this for multi-line conditions, but this one fits in a single line,
> so we can put it outside, and that way, it doesn't look like a parens
> is missing.

Make sense to me, modified patch below.

Chris
---
2012-03-08  Chris January  <chris.january@allinea.com>

        * rs6000-tdep.c (skip_prologue): Support the oril r29, r1, 0x0
	instruction.
---
diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index a8ff777..9d4fd40 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -1822,6 +1822,15 @@ skip_prologue (struct gdbarch *gdbarch, CORE_ADDR
pc, CORE_ADDR lim_pc,
 
          /* Set up frame pointer */
        }
+      else if (op == 0x603d0000)       /* oril r29, r1, 0x0 */
+       {
+         fdata->frameless = 0;
+         framep = 1;
+         fdata->alloca_reg = (tdep->ppc_gp0_regnum + 29);
+         continue;
+
+         /* Another way to set up the frame pointer.  */
+       }
       else if (op == 0x603f0000        /* oril r31, r1, 0x0 */
               || op == 0x7c3f0b78)
        {                       /* mr r31, r1 */