From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10652 invoked by alias); 13 Mar 2012 16:50:20 -0000 Received: (qmail 10643 invoked by uid 22791); 13 Mar 2012 16:50:20 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Mar 2012 16:50:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 571871C6311; Tue, 13 Mar 2012 12:50:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yGsQWwvNwk8f; Tue, 13 Mar 2012 12:50:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1C8E21C630C; Tue, 13 Mar 2012 12:50:05 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id CE5BD145615; Tue, 13 Mar 2012 09:49:58 -0700 (PDT) Date: Tue, 13 Mar 2012 16:50:00 -0000 From: Joel Brobecker To: Chris January Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] AIX: Add another way of setting up the frame pointer to skip_prologue Message-ID: <20120313164958.GR2853@adacore.com> References: <1331217602.2742.14.camel@gumtree> <20120309194834.GG2853@adacore.com> <1331558060.2783.20.camel@gumtree> <201203121343.q2CDhGKx015959@glazunov.sibelius.xs4all.nl> <1331651889.2755.4.camel@gumtree> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331651889.2755.4.camel@gumtree> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00443.txt.bz2 Re: 2012-03-08 Chris January * rs6000-tdep.c (skip_prologue): Support the oril r29, r1, 0x0 instruction. > > > > Same comments as before: Looks good, but has it been validated against > > > > the testsuite? > > > > > > No, I have not got the test suite working reliably on AIX yet. > > > > If you have a Linux PowerPC box available, you could run the testsuite > > there to check for regressions. > > I did just that, and there were no regressions. Thanks, Chris. I checked the patch in for you. Have we started the process for giving you write priviledges so that you can commit the patches yourself? PS: Does your mailer wrap long lines? If that's the case, can you send patches in attachment instead? I couldn't get this patch to apply even after fixing an obvious long-line automatic-wrap-around. So I applied it by hand, and verified that the file still compiled. -- Joel