From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Thomas Schwinge <thomas@schwinge.name>
Subject: [RFC] sh-tdep.c: Don't fetch FPSCR register if it doesn't exist
Date: Thu, 01 Mar 2012 00:34:00 -0000 [thread overview]
Message-ID: <20120229173408.78699013@mesquite.lan> (raw)
The patch below fixes 119 failures for the default sh-elf multilib (using
sh-sim.) I can post a list if there's interest in seeing them.
Comments? Is there a better way to test for the existence of a register?
Kevin
* sh-tdep.c (sh_frame_cache): Don't fetch the FPSCR register
unless it exists for this architecture.
Index: sh-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sh-tdep.c,v
retrieving revision 1.239
diff -u -p -r1.239 sh-tdep.c
--- sh-tdep.c 27 Feb 2012 16:40:48 -0000 1.239
+++ sh-tdep.c 1 Mar 2012 00:31:31 -0000
@@ -2553,7 +2553,12 @@ sh_frame_cache (struct frame_info *this_
if (cache->pc != 0)
{
ULONGEST fpscr;
- fpscr = get_frame_register_unsigned (this_frame, FPSCR_REGNUM);
+ const char *fpscr_name = gdbarch_register_name (gdbarch, FPSCR_REGNUM);
+
+ if (fpscr_name && fpscr_name[0])
+ fpscr = get_frame_register_unsigned (this_frame, FPSCR_REGNUM);
+ else
+ fpscr = 0;
sh_analyze_prologue (gdbarch, cache->pc, current_pc, cache, fpscr);
}
next reply other threads:[~2012-03-01 0:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 0:34 Kevin Buettner [this message]
2012-03-01 1:33 ` Joel Brobecker
2012-03-01 5:09 ` Kevin Buettner
2012-03-01 10:30 ` Thomas Schwinge
2012-03-01 19:11 ` Kevin Buettner
2012-03-02 9:24 ` Thomas Schwinge
2012-03-02 13:46 ` Kevin Buettner
2012-03-03 1:29 ` Kevin Buettner
2012-03-01 15:57 ` Joel Brobecker
2012-03-01 19:10 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229173408.78699013@mesquite.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox