From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20419 invoked by alias); 1 Mar 2012 00:34:30 -0000 Received: (qmail 20271 invoked by uid 22791); 1 Mar 2012 00:34:29 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 00:34:12 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q210YAJV015046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 29 Feb 2012 19:34:10 -0500 Received: from mesquite.lan (ovpn-113-100.phx2.redhat.com [10.3.113.100]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q210Y8cC031066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 29 Feb 2012 19:34:09 -0500 Date: Thu, 01 Mar 2012 00:34:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Thomas Schwinge Subject: [RFC] sh-tdep.c: Don't fetch FPSCR register if it doesn't exist Message-ID: <20120229173408.78699013@mesquite.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00001.txt.bz2 The patch below fixes 119 failures for the default sh-elf multilib (using sh-sim.) I can post a list if there's interest in seeing them. Comments? Is there a better way to test for the existence of a register? Kevin * sh-tdep.c (sh_frame_cache): Don't fetch the FPSCR register unless it exists for this architecture. Index: sh-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sh-tdep.c,v retrieving revision 1.239 diff -u -p -r1.239 sh-tdep.c --- sh-tdep.c 27 Feb 2012 16:40:48 -0000 1.239 +++ sh-tdep.c 1 Mar 2012 00:31:31 -0000 @@ -2553,7 +2553,12 @@ sh_frame_cache (struct frame_info *this_ if (cache->pc != 0) { ULONGEST fpscr; - fpscr = get_frame_register_unsigned (this_frame, FPSCR_REGNUM); + const char *fpscr_name = gdbarch_register_name (gdbarch, FPSCR_REGNUM); + + if (fpscr_name && fpscr_name[0]) + fpscr = get_frame_register_unsigned (this_frame, FPSCR_REGNUM); + else + fpscr = 0; sh_analyze_prologue (gdbarch, cache->pc, current_pc, cache, fpscr); }