From: Thomas Schwinge <thomas@codesourcery.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] sh-tdep.c: Don't fetch FPSCR register if it doesn't exist
Date: Thu, 01 Mar 2012 10:30:00 -0000 [thread overview]
Message-ID: <877gz44nre.fsf@schwinge.name> (raw)
In-Reply-To: <20120229220932.17ad0d5f@mesquite.lan>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
Hi!
On Wed, 29 Feb 2012 22:09:32 -0700, Kevin Buettner <kevinb@redhat.com> wrote:
> * sh-tdep.c (sh_frame_cache): Don't fetch the FPSCR register
> unless it exists for this architecture.
Your reasoning and this patch look good to me. (But I didn't test it.)
Basically, you now relay the test to sh_register_reggroup_p, which
already contains the FPSCR existence test you first proposed. (The same
test exists in arch-utils.c:legacy_register_sim_regno, by the way.)
Still learning about GDB's code layout -- is there any benefit in
invoking gdbarch_register_reggroup_p (as you're doing) in contrast to
directly going for sh_register_reggroup_p?
Also, we assume that simply passing 0 for fpscr to sh_analyze_prologue
doesn't do any harm (which it doesn't). (Worth a comment, perhaps?)
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2012-03-01 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 0:34 Kevin Buettner
2012-03-01 1:33 ` Joel Brobecker
2012-03-01 5:09 ` Kevin Buettner
2012-03-01 10:30 ` Thomas Schwinge [this message]
2012-03-01 19:11 ` Kevin Buettner
2012-03-02 9:24 ` Thomas Schwinge
2012-03-02 13:46 ` Kevin Buettner
2012-03-03 1:29 ` Kevin Buettner
2012-03-01 15:57 ` Joel Brobecker
2012-03-01 19:10 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gz44nre.fsf@schwinge.name \
--to=thomas@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox