From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 06/14] -Wmissing-prototypes: The TUI.
Date: Wed, 29 Feb 2012 16:18:00 -0000 [thread overview]
Message-ID: <20120229161810.23918.3306.stgit@hit-nxdomain.opendns.com> (raw)
In-Reply-To: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com>
$ make WERROR_CFLAGS="-Wmissing-prototypes" tui-data.o tui-regs.o 1>/dev/null
../../src/gdb/tui/tui-data.c:316:1: warning: no previous prototype for ‘set_gen_win_origin’ [-Wmissing-prototypes]
../../src/gdb/tui/tui-regs.c:137:1: warning: no previous prototype for ‘tui_last_reg_element_no_in_line’ [-Wmissing-prototypes]
Turns out these functions are orphans.
2012-02-29 Pedro Alves <palves@redhat.com>
* tui/tui-data.c (set_gen_win_origin): Delete.
* tui/tui-data.h (tui_set_gen_win_origin): Delete declaration.
* tui/tui-regs.c (tui_last_reg_element_no_in_line): Delete.
---
gdb/tui/tui-data.c | 10 ----------
gdb/tui/tui-data.h | 2 --
gdb/tui/tui-regs.c | 13 -------------
3 files changed, 0 insertions(+), 25 deletions(-)
diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c
index e7e0749..1f74b3f 100644
--- a/gdb/tui/tui-data.c
+++ b/gdb/tui/tui-data.c
@@ -311,16 +311,6 @@ tui_set_current_layout_to (enum tui_layout_type new_layout)
}
-/* Set the origin of the window. */
-void
-set_gen_win_origin (struct tui_gen_win_info *win_info,
- int x, int y)
-{
- win_info->origin.x = x;
- win_info->origin.y = y;
-}
-
-
/*****************************
** OTHER PUBLIC FUNCTIONS
*****************************/
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 50619d2..5df73d2 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -341,8 +341,6 @@ extern int tui_term_height (void);
extern void tui_set_term_height_to (int);
extern int tui_term_width (void);
extern void tui_set_term_width_to (int);
-extern void tui_set_gen_win_origin (struct tui_gen_win_info *,
- int, int);
extern struct tui_gen_win_info *tui_locator_win_info_ptr (void);
extern struct tui_gen_win_info *tui_source_exec_info_win_ptr (void);
extern struct tui_gen_win_info *tui_disassem_exec_info_win_ptr (void);
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index a093e91..62c0fad 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -131,19 +131,6 @@ tui_first_reg_element_no_inline (int line_no)
}
-/* Answer the index of the last element in line_no. If line_no is
- past the register area (-1) is returned. */
-int
-tui_last_reg_element_no_in_line (int line_no)
-{
- if ((line_no * TUI_DATA_WIN->detail.data_display_info.regs_column_count) <=
- TUI_DATA_WIN->detail.data_display_info.regs_content_count)
- return ((line_no + 1) *
- TUI_DATA_WIN->detail.data_display_info.regs_column_count) - 1;
- else
- return (-1);
-}
-
/* Show the registers of the given group in the data window
and refresh the window. */
void
next prev parent reply other threads:[~2012-02-29 16:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 16:17 [PATCH 00/14] -Wmissing-prototypes: Intro Pedro Alves
2012-02-29 16:17 ` [PATCH 01/14] -Wmissing-prototypes: Ada Pedro Alves
2012-02-29 17:19 ` Joel Brobecker
2012-02-29 16:17 ` [PATCH 02/14] -Wmissing-prototypes: proc-service Pedro Alves
2012-02-29 16:17 ` [PATCH 03/14] -Wmissing-prototypes: Garbage collect inferior.c:delete_threads_of_inferior Pedro Alves
2012-02-29 16:18 ` [PATCH 04/14] -Wmissing-prototypes: Python Pedro Alves
2012-02-29 18:09 ` Tom Tromey
2012-02-29 16:18 ` Pedro Alves [this message]
2012-02-29 16:18 ` [PATCH 05/14] -Wmissing-prototypes: The encode_actions hack Pedro Alves
2012-02-29 16:19 ` [PATCH 07/14] -Wmissing-prototypes: inline-frame.c Pedro Alves
2012-02-29 16:20 ` [PATCH 08/14] -Wmissing-prototypes: The find_and_open_source hack Pedro Alves
2012-02-29 16:20 ` [PATCH 10/14] -Wmissing-prototypes: common/signals.c Pedro Alves
2012-02-29 16:21 ` [PATCH 11/14] -Wmissing-prototypes: observer.c's testsuite helpers Pedro Alves
2012-02-29 16:44 ` [PATCH 14/14] -Wmissing-prototypes: Build with -Wmissing-prototypes by default Pedro Alves
2012-02-29 19:11 ` Tom Tromey
2012-02-29 22:41 ` Joel Brobecker
2012-02-29 17:07 ` [PATCH 13/14] -Wmissing-prototypes: All others Pedro Alves
2012-02-29 17:08 ` [PATCH 09/14] -Wmissing-prototypes: jit-reader.in (plugin_is_GPL_compatible) Pedro Alves
2012-02-29 17:18 ` Pedro Alves
2012-03-01 21:25 ` C version of jit-reader.h:plugin_is_GPL_compatible broken Pedro Alves
2012-02-29 17:12 ` [PATCH 12/14] -Wmissing-prototypes: Hook linux_has_shared_address_space Pedro Alves
2012-02-29 17:27 ` [PATCH 00/14] -Wmissing-prototypes: Intro Joel Brobecker
2012-02-29 17:42 ` Joel Brobecker
2012-03-01 21:19 ` Pedro Alves
2012-03-02 12:03 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229161810.23918.3306.stgit@hit-nxdomain.opendns.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox