Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 04/14] -Wmissing-prototypes: Python.
Date: Wed, 29 Feb 2012 16:18:00 -0000	[thread overview]
Message-ID: <20120229161737.23918.81678.stgit@hit-nxdomain.opendns.com> (raw)
In-Reply-To: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com>

../../src/gdb/python/py-breakpoint.c:720:1: warning: no previous prototype for ‘gdbpy_should_stop’ [-Wmissing-prototypes]
../../src/gdb/python/py-breakpoint.c:767:1: warning: no previous prototype for ‘gdbpy_breakpoint_has_py_cond’ [-Wmissing-prototypes]
../../src/gdb/python/py-continueevent.c:25:1: warning: no previous prototype for ‘create_continue_event_object’ [-Wmissing-prototypes]
../../src/gdb/python/py-lazy-string.c:88:1: warning: no previous prototype for ‘stpy_get_type’ [-Wmissing-prototypes]
../../src/gdb/python/py-newobjfileevent.c:25:1: warning: no previous prototype for ‘create_new_objfile_event_object’ [-Wmissing-prototypes]
../../src/gdb/python/py-utils.c:143:1: warning: no previous prototype for ‘unicode_to_target_python_string’ [-Wmissing-prototypes]
../../src/gdb/python/py-value.c:165:1: warning: no previous prototype for ‘preserve_python_values’ [-Wmissing-prototypes]

Most are obvious, and I think including the public "python.h" in
py-breakpoint.c and py-value.c is the right thing to do, given that
the functions in question are indeed public and to be used by core
gdb.

2012-02-29  Pedro Alves  <palves@redhat.com>

	* python/py-breakpoint.c: Include python.h.
	* python/py-continueevent.c (create_continue_event_object): Make static.
	* python/py-lazy-string.c (stpy_get_type): Make static.
	* python/py-newobjfileevent.c (create_new_objfile_event_object): Make static.
	* python/py-utils.c (unicode_to_target_python_string): Make static.
	* python/py-value.c: Include python.h.
---
 gdb/python/py-breakpoint.c      |    1 +
 gdb/python/py-continueevent.c   |    2 +-
 gdb/python/py-lazy-string.c     |    2 +-
 gdb/python/py-newobjfileevent.c |    2 +-
 gdb/python/py-utils.c           |    2 +-
 gdb/python/py-value.c           |    1 +
 6 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c
index 195ed2b..c13fb95 100644
--- a/gdb/python/py-breakpoint.c
+++ b/gdb/python/py-breakpoint.c
@@ -21,6 +21,7 @@
 #include "value.h"
 #include "exceptions.h"
 #include "python-internal.h"
+#include "python.h"
 #include "charset.h"
 #include "breakpoint.h"
 #include "gdbcmd.h"
diff --git a/gdb/python/py-continueevent.c b/gdb/python/py-continueevent.c
index 4582fb5..2a1524e 100644
--- a/gdb/python/py-continueevent.c
+++ b/gdb/python/py-continueevent.c
@@ -21,7 +21,7 @@
 
 static PyTypeObject continue_event_object_type;
 
-PyObject *
+static PyObject *
 create_continue_event_object (void)
 {
   return create_thread_event_object (&continue_event_object_type);
diff --git a/gdb/python/py-lazy-string.c b/gdb/python/py-lazy-string.c
index 11048b3..3c90829 100644
--- a/gdb/python/py-lazy-string.c
+++ b/gdb/python/py-lazy-string.c
@@ -84,7 +84,7 @@ stpy_get_length (PyObject *self, void *closure)
   return PyLong_FromLong (self_string->length);
 }
 
-PyObject *
+static PyObject *
 stpy_get_type (PyObject *self, void *closure)
 {
   lazy_string_object *str_obj = (lazy_string_object *) self;
diff --git a/gdb/python/py-newobjfileevent.c b/gdb/python/py-newobjfileevent.c
index 1e26b04..d014be6 100644
--- a/gdb/python/py-newobjfileevent.c
+++ b/gdb/python/py-newobjfileevent.c
@@ -21,7 +21,7 @@
 
 static PyTypeObject new_objfile_event_object_type;
 
-PyObject *
+static PyObject *
 create_new_objfile_event_object (struct objfile *objfile)
 {
   PyObject *objfile_event;
diff --git a/gdb/python/py-utils.c b/gdb/python/py-utils.c
index bf50e37..d5d0e431 100644
--- a/gdb/python/py-utils.c
+++ b/gdb/python/py-utils.c
@@ -139,7 +139,7 @@ unicode_to_target_string (PyObject *unicode_str)
    object converted to the target's charset.  If an error occurs
    during the conversion, NULL will be returned and a python exception
    will be set.  */
-PyObject *
+static PyObject *
 unicode_to_target_python_string (PyObject *unicode_str)
 {
   return unicode_to_encoded_python_string (unicode_str,
diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c
index 760360e..44443e0 100644
--- a/gdb/python/py-value.c
+++ b/gdb/python/py-value.c
@@ -28,6 +28,7 @@
 #include "infcall.h"
 #include "expression.h"
 #include "cp-abi.h"
+#include "python.h"
 
 #ifdef HAVE_PYTHON
 


  parent reply	other threads:[~2012-02-29 16:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 16:17 [PATCH 00/14] -Wmissing-prototypes: Intro Pedro Alves
2012-02-29 16:17 ` [PATCH 02/14] -Wmissing-prototypes: proc-service Pedro Alves
2012-02-29 16:17 ` [PATCH 03/14] -Wmissing-prototypes: Garbage collect inferior.c:delete_threads_of_inferior Pedro Alves
2012-02-29 16:17 ` [PATCH 01/14] -Wmissing-prototypes: Ada Pedro Alves
2012-02-29 17:19   ` Joel Brobecker
2012-02-29 16:18 ` [PATCH 06/14] -Wmissing-prototypes: The TUI Pedro Alves
2012-02-29 16:18 ` Pedro Alves [this message]
2012-02-29 18:09   ` [PATCH 04/14] -Wmissing-prototypes: Python Tom Tromey
2012-02-29 16:18 ` [PATCH 05/14] -Wmissing-prototypes: The encode_actions hack Pedro Alves
2012-02-29 16:19 ` [PATCH 07/14] -Wmissing-prototypes: inline-frame.c Pedro Alves
2012-02-29 16:20 ` [PATCH 10/14] -Wmissing-prototypes: common/signals.c Pedro Alves
2012-02-29 16:20 ` [PATCH 08/14] -Wmissing-prototypes: The find_and_open_source hack Pedro Alves
2012-02-29 16:21 ` [PATCH 11/14] -Wmissing-prototypes: observer.c's testsuite helpers Pedro Alves
2012-02-29 16:44 ` [PATCH 14/14] -Wmissing-prototypes: Build with -Wmissing-prototypes by default Pedro Alves
2012-02-29 19:11   ` Tom Tromey
2012-02-29 22:41     ` Joel Brobecker
2012-02-29 17:07 ` [PATCH 13/14] -Wmissing-prototypes: All others Pedro Alves
2012-02-29 17:08 ` [PATCH 09/14] -Wmissing-prototypes: jit-reader.in (plugin_is_GPL_compatible) Pedro Alves
2012-02-29 17:18   ` Pedro Alves
2012-03-01 21:25     ` C version of jit-reader.h:plugin_is_GPL_compatible broken Pedro Alves
2012-02-29 17:12 ` [PATCH 12/14] -Wmissing-prototypes: Hook linux_has_shared_address_space Pedro Alves
2012-02-29 17:27 ` [PATCH 00/14] -Wmissing-prototypes: Intro Joel Brobecker
2012-02-29 17:42   ` Joel Brobecker
2012-03-01 21:19 ` Pedro Alves
2012-03-02 12:03   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120229161737.23918.81678.stgit@hit-nxdomain.opendns.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox