[PATCH 01/14] -Wmissing-prototypes: Ada.

[Pedro Alves <palves@redhat.com>]

$ make WERROR_CFLAGS="-Wmissing-prototypes" ada-lang.o ada-exp.o 1>/dev/null
../../src/gdb/ada-lang.c:10536:1: warning: no previous prototype for ‘ada_modulus_from_name’ [-Wmissing-prototypes]
In file included from ../../src/gdb/ada-exp.y:765:0:
../../src/gdb/ada-lex.l:298:1: warning: no previous prototype for ‘lexer_init’ [-Wmissing-prototypes]

ada_modulus_from_name was made orphan by:

commit 345826d325cdf374077d253274477c5b56b45edc
Author: Paul N. Hilfinger <hilfinger@adacore.com>
Date:   Mon Dec 14 06:19:12 2009 +0000

...
	* ada-lang.c (ada_modulus): Use new extended bound values.
...

Okay to apply?

2012-02-29  Pedro Alves  <palves@redhat.com>

	* ada-lang.c (ada_modulus_from_name): Delete.
	* ada-lex.l (lexer_init): Make static.
---
 gdb/ada-lang.c |   31 -------------------------------
 gdb/ada-lex.l  |    2 +-
 2 files changed, 1 insertions(+), 32 deletions(-)

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 107df93..84049eb 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -10528,37 +10528,6 @@ ada_is_modular_type (struct type *type)
           && TYPE_UNSIGNED (subranged_type));
 }
 
-/* Try to determine the lower and upper bounds of the given modular type
-   using the type name only.  Return non-zero and set L and U as the lower
-   and upper bounds (respectively) if successful.  */
-
-int
-ada_modulus_from_name (struct type *type, ULONGEST *modulus)
-{
-  const char *name = ada_type_name (type);
-  const char *suffix;
-  int k;
-  LONGEST U;
-
-  if (name == NULL)
-    return 0;
-
-  /* Discrete type bounds are encoded using an __XD suffix.  In our case,
-     we are looking for static bounds, which means an __XDLU suffix.
-     Moreover, we know that the lower bound of modular types is always
-     zero, so the actual suffix should start with "__XDLU_0__", and
-     then be followed by the upper bound value.  */
-  suffix = strstr (name, "__XDLU_0__");
-  if (suffix == NULL)
-    return 0;
-  k = 10;
-  if (!ada_scan_number (suffix, k, &U, NULL))
-    return 0;
-
-  *modulus = (ULONGEST) U + 1;
-  return 1;
-}
-
 /* Assuming ada_is_modular_type (TYPE), the modulus of TYPE.  */
 
 ULONGEST
diff --git a/gdb/ada-lex.l b/gdb/ada-lex.l
index 48667d0..784edbf 100644
--- a/gdb/ada-lex.l
+++ b/gdb/ada-lex.l
@@ -293,7 +293,7 @@ false		{ return FALSEKEYWORD; }
 
 /* Initialize the lexer for processing new expression. */
 
-void
+static void
 lexer_init (FILE *inp)
 {
   BEGIN INITIAL;