Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix another stale frame_info *
Date: Fri, 24 Feb 2012 16:05:00 -0000	[thread overview]
Message-ID: <20120224160045.GA22087@host2.jankratochvil.net> (raw)
In-Reply-To: <4F47B221.8020106@redhat.com>

On Fri, 24 Feb 2012 16:52:01 +0100, Pedro Alves wrote:
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -9853,6 +9853,9 @@ until_break_command (char *arg, int from_tty, int anywhere)
>    struct symtabs_and_lines sals;
>    struct symtab_and_line sal;
>    struct frame_info *frame = get_selected_frame (NULL);
> +  struct gdbarch *gdbarch = get_frame_arch (frame);
> +  struct frame_id stack_frame_id = get_stack_frame_id (frame);
> +  struct frame_id caller_frame_id = frame_unwind_caller_id (frame);

OK with it.

'gdbarch' should be called 'frame_gdbarch' as this function deals both with
FRAME and previous-of-FRAME (caller_frame_id).


Thanks,
Jan


  reply	other threads:[~2012-02-24 16:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  8:38 Jan Kratochvil
2012-02-24 15:37 ` Pedro Alves
2012-02-24 15:41   ` Jan Kratochvil
2012-02-24 15:54     ` Pedro Alves
2012-02-24 16:05       ` Jan Kratochvil [this message]
2012-02-24 16:32         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120224160045.GA22087@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox