Re: [patch] Fix another stale frame_info *

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Fri, 24 Feb 2012 16:28:04 +0100, Pedro Alves wrote:
> Yeah.  If we swap the order we do things, we can avoid needing this
> bit.  WDYT?  It seems slightly cleaner to me.  Tested on x86_64 Fedora 16.

In general yes just this patch is not there yet.


> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
[...]
>    if (frame_id_p (frame_unwind_caller_id (frame)))
>      {
> -      sal = find_pc_line (frame_unwind_caller_pc (frame), 0);
> -      sal.pc = frame_unwind_caller_pc (frame);
> +      struct symtab_and_line sal2;
> +
> +      sal2 = find_pc_line (frame_unwind_caller_pc (frame), 0);
> +      sal2.pc = frame_unwind_caller_pc (frame);
>        breakpoint2 = set_momentary_breakpoint (frame_unwind_caller_arch (frame),
> -					      sal,
> +					      sal2,
>  					      frame_unwind_caller_id (frame),
>  					      bp_until);
>        make_cleanup_delete_breakpoint (breakpoint2);

Here is still in the code:
      set_longjmp_breakpoint (tp, frame_unwind_caller_id (frame));



Thanks,
Jan