From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88208-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27133 invoked by alias); 24 Feb 2012 16:01:07 -0000
Received: (qmail 27123 invoked by uid 22791); 24 Feb 2012 16:01:04 -0000
X-SWARE-Spam-Status: No, hits=-6.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 16:00:51 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OG0nom010926	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 24 Feb 2012 11:00:51 -0500
Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1OG0jAA026404	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 24 Feb 2012 11:00:48 -0500
Date: Fri, 24 Feb 2012 16:05:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix another stale frame_info *
Message-ID: <20120224160045.GA22087@host2.jankratochvil.net>
References: <20120223083743.GA5696@host2.jankratochvil.net> <4F47AC84.9080807@redhat.com> <20120224153702.GA20145@host2.jankratochvil.net> <4F47B221.8020106@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F47B221.8020106@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00580.txt.bz2

On Fri, 24 Feb 2012 16:52:01 +0100, Pedro Alves wrote:
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -9853,6 +9853,9 @@ until_break_command (char *arg, int from_tty, int anywhere)
>    struct symtabs_and_lines sals;
>    struct symtab_and_line sal;
>    struct frame_info *frame = get_selected_frame (NULL);
> +  struct gdbarch *gdbarch = get_frame_arch (frame);
> +  struct frame_id stack_frame_id = get_stack_frame_id (frame);
> +  struct frame_id caller_frame_id = frame_unwind_caller_id (frame);

OK with it.

'gdbarch' should be called 'frame_gdbarch' as this function deals both with
FRAME and previous-of-FRAME (caller_frame_id).


Thanks,
Jan