From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH]
Date: Wed, 18 Jan 2012 05:04:00 -0000 [thread overview]
Message-ID: <20120118045128.GZ31383@adacore.com> (raw)
In-Reply-To: <m3y5t58wmh.fsf@redhat.com>
> This patch is going to be important for the coming SystemTap patches
> that I plan to submit this week, and I know GDB has a rule to avoid
> premature modification of the code before a patch is posted, but I
> believe this is a good cleanup to have in any case.
[...]
> 2012-01-18 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * parse.c (initialize_expout): New function.
> (reallocate_expout): Likewise.
> (parse_exp_in_context): Use `initialize_expout' and
> `reallocate_expout' when appropriate.
FWIW, it seems OK to me on its own. I like the fact that you made
the initial_size and gdbarch parameters.
The description does seem to mention an argument that has not been
added yet (parser_state PS). I haven't followed the discussion on
the thread, but have we decided to keep "ps" as the name of the
parser_state argument?
--
Joel
next prev parent reply other threads:[~2012-01-18 4:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 4:35 [PATCH] Sergio Durigan Junior
2012-01-18 4:52 ` [PATCH] Add initialize and reallocate methods to parser expout Sergio Durigan Junior
2012-01-18 5:04 ` Joel Brobecker [this message]
2012-01-18 5:17 ` [PATCH] Sergio Durigan Junior
2012-01-18 12:48 ` [PATCH] Joel Brobecker
2012-01-18 14:34 ` [PATCH] Sergio Durigan Junior
-- strict thread matches above, loose matches on Subject: below --
2013-01-23 19:10 [patch] Doug Evans
2009-05-06 0:35 [PATCH] Maxim Grigoriev
2004-04-18 13:09 [PATCH] Mark Kettenis
2004-04-09 16:31 [PATCH] Mark Kettenis
2003-10-30 20:21 [PATCH] Mark Kettenis
2003-10-30 19:36 [PATCH] Mark Kettenis
2003-03-01 13:09 [PATCH] Mark Kettenis
2003-03-03 17:33 ` [PATCH] David Carlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118045128.GZ31383@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox