Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: gdb-patches@sources.redhat.com
Subject: [PATCH]
Date: Sun, 18 Apr 2004 13:09:00 -0000	[thread overview]
Message-ID: <200404181309.i3ID9fvf061665@elgar.kettenis.dyndns.org> (raw)

While working on OpenBSD/m68k support, I couldn't resist tweaking some
comments such that things are a bit more consistent regarding to
coding style and such.  I also tweaked the comment about register
numbers.  For m68k these are all "real" so the comment about
pseudo-registers is just confusing.

Committed,

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* m68k-tdep.h: Tweak comments.
	* m68k-tdep.c: Tweak comment.

Index: m68k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68k-tdep.c,v
retrieving revision 1.81
diff -u -p -r1.81 m68k-tdep.c
--- m68k-tdep.c 23 Mar 2004 14:47:56 -0000 1.81
+++ m68k-tdep.c 18 Apr 2004 13:00:24 -0000
@@ -1,4 +1,4 @@
-/* Target dependent code for the Motorola 68000 series.
+/* Target-dependent code for the Motorola 68000 series.
 
    Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1999, 2000,
    2001, 2002, 2003, 2004 Free Software Foundation, Inc.
Index: m68k-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/m68k-tdep.h,v
retrieving revision 1.4
diff -u -p -r1.4 m68k-tdep.h
--- m68k-tdep.h 9 Jul 2003 21:36:08 -0000 1.4
+++ m68k-tdep.h 18 Apr 2004 13:00:24 -0000
@@ -1,6 +1,7 @@
-/* Common target dependent code for the Motorola 68000 series.
-   Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1999, 2000, 2001, 2003
-   Free Software Foundation, Inc.
+/* Target-dependent code for the Motorola 68000 series.
+
+   Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1999, 2000,
+   2001, 2003, 2004 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -24,30 +25,26 @@
 
 struct frame_info;
 
-/* Register numbers of various important registers.
-   Note that some of these values are "real" register numbers,
-   and correspond to the general registers of the machine,
-   and some are "phony" register numbers which are too large
-   to be actual register numbers as far as the user is concerned
-   but do serve to get the desired values when passed to read_register.  */
+/* Register numbers of various important registers.  */
 
-enum
+enum m68k_regnum
 {
   M68K_D0_REGNUM = 0,
   M68K_D1_REGNUM = 1,
   M68K_A0_REGNUM = 8,
   M68K_A1_REGNUM = 9,
-  M68K_FP_REGNUM = 14,		/* Contains address of executing stack frame */
-  M68K_SP_REGNUM = 15,		/* Contains address of top of stack */
-  M68K_PS_REGNUM = 16,		/* Contains processor status */
-  M68K_PC_REGNUM = 17,		/* Contains program counter */
-  M68K_FP0_REGNUM = 18,		/* Floating point register 0 */
-  M68K_FPC_REGNUM = 26,		/* 68881 control register */
-  M68K_FPS_REGNUM = 27,		/* 68881 status register */
+  M68K_FP_REGNUM = 14,		/* Address of executing stack frame.  */
+  M68K_SP_REGNUM = 15,		/* Address of top of stack.  */
+  M68K_PS_REGNUM = 16,		/* Processor status.  */
+  M68K_PC_REGNUM = 17,		/* Program counter.  */
+  M68K_FP0_REGNUM = 18,		/* Floating point register 0.  */
+  M68K_FPC_REGNUM = 26,		/* 68881 control register.  */
+  M68K_FPS_REGNUM = 27,		/* 68881 status register.  */
   M68K_FPI_REGNUM = 28
 };
 
-#define M68K_NUM_REGS (M68K_FPI_REGNUM + 1)
+/* Number of machine registers.  */
+#define M68K_NUM_REGS	(M68K_FPI_REGNUM + 1)
 
 /* Size of the largest register.  */
 #define M68K_MAX_REGISTER_SIZE	12
@@ -70,6 +67,7 @@ enum struct_return
 };
 
 /* Target-dependent structure in gdbarch.  */
+
 struct gdbarch_tdep
 {
   /* Offset to PC value in the jump buffer.  If this is negative,
@@ -85,4 +83,4 @@ struct gdbarch_tdep
   enum struct_return struct_return;
 };
 
-#endif /* M68K_TDEP_H */
+#endif /* m68k-tdep.h */


             reply	other threads:[~2004-04-18 13:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-18 13:09 Mark Kettenis [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-01-23 19:10 [patch] Doug Evans
2012-01-18  4:35 [PATCH] Sergio Durigan Junior
2012-01-18  5:04 ` [PATCH] Joel Brobecker
2012-01-18  5:17   ` [PATCH] Sergio Durigan Junior
2012-01-18 12:48     ` [PATCH] Joel Brobecker
2012-01-18 14:34       ` [PATCH] Sergio Durigan Junior
2009-05-06  0:35 [PATCH] Maxim Grigoriev
2004-04-09 16:31 [PATCH] Mark Kettenis
2003-10-30 20:21 [PATCH] Mark Kettenis
2003-10-30 19:36 [PATCH] Mark Kettenis
2003-03-01 13:09 [PATCH] Mark Kettenis
2003-03-03 17:33 ` [PATCH] David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200404181309.i3ID9fvf061665@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox