From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32219 invoked by alias); 18 Jan 2012 04:52:16 -0000 Received: (qmail 32210 invoked by uid 22791); 18 Jan 2012 04:52:15 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jan 2012 04:52:02 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 104BC2BAE6B; Tue, 17 Jan 2012 23:52:02 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Hds-JbCuW3bR; Tue, 17 Jan 2012 23:52:02 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 96D0A2BADE9; Tue, 17 Jan 2012 23:52:01 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BCE04145615; Wed, 18 Jan 2012 08:51:28 +0400 (RET) Date: Wed, 18 Jan 2012 05:04:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Message-ID: <20120118045128.GZ31383@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00661.txt.bz2 > This patch is going to be important for the coming SystemTap patches > that I plan to submit this week, and I know GDB has a rule to avoid > premature modification of the code before a patch is posted, but I > believe this is a good cleanup to have in any case. [...] > 2012-01-18 Sergio Durigan Junior > > * parse.c (initialize_expout): New function. > (reallocate_expout): Likewise. > (parse_exp_in_context): Use `initialize_expout' and > `reallocate_expout' when appropriate. FWIW, it seems OK to me on its own. I like the fact that you made the initial_size and gdbarch parameters. The description does seem to mention an argument that has not been added yet (parser_state PS). I haven't followed the discussion on the thread, but have we decided to keep "ps" as the name of the parser_state argument? -- Joel