Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Paul Hilfinger <Hilfinger@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add testcase for locals identified with FUNCTION::VAR syntax.
Date: Sat, 31 Dec 2011 07:05:00 -0000	[thread overview]
Message-ID: <20111231033856.GC13974@adacore.com> (raw)
In-Reply-To: <20111230215407.B6DB13FEE8@kwai.gnat.com>

Hi Paul,

> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 91b9487..ef85468 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,12 @@
> +2011-12-30  Paul Hilfinger  <hilfingr@adacore.com>
> +
> +	* gdb.base/recpar.exp: Use standard definitions ($decimal, $hex)
> +	in place of local ones.
> +
> +2011-12-27  Paul Hilfinger  <hilfingr@adacore.com>
> +
> +	* gdb.base/recpar.c, gdb.base/recpar.exp: New files.
> +
>  2011-12-30  Edjunior Machado  <emachado@linux.vnet.ibm.com>

In the ChangeLog file, I would merge these two entries.  I think
that the ChangeLog is meant to track the changes in the repository,
and does not need to track the iterations that the patch went through
during review...

-- 
Joel


  reply	other threads:[~2011-12-31  3:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30 22:27 Paul Hilfinger
2011-12-31  7:05 ` Joel Brobecker [this message]
2011-12-31 15:12   ` Paul Hilfinger
  -- strict thread matches above, loose matches on Subject: below --
2011-12-27 21:25 Paul Hilfinger
2011-12-28  1:38 ` Doug Evans
2011-12-28  3:43   ` Paul Hilfinger
2011-12-28  4:04   ` Joel Brobecker
2011-12-28 15:57     ` Paul Hilfinger
2011-12-29 11:10       ` Joel Brobecker
2011-12-28 18:02     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111231033856.GC13974@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Hilfinger@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox