Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Hilfinger@adacore.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Add testcase for locals identified with FUNCTION::VAR syntax.
Date: Wed, 28 Dec 2011 04:04:00 -0000	[thread overview]
Message-ID: <20111228035045.GK23376@adacore.com> (raw)
In-Reply-To: <CADPb22Sxrmu9Hy20UYG4-xVWdW8ihfO_5RX_vQL2OJT6H7eUxA@mail.gmail.com>

Hi Doug,

> > +# Some convenient regular expressions...
> > +set num "\[0-9\]+"
> Delete, use $decimal.
>
> > +set addr "0x\[0-9a-zA-Z\]+"
>
> This could be replaced with $hex, or do "set addr $hex".  Either is
> fine with me.

Do you know where these are defined? And are there any other such
useful globals that we can use? I need to document them in the
testing cookbook, because I keep looking for them, and then
eventually redefine them over and over again...

Thanks!

> I notice scope.exp has similar tests.
> Would it make sense to move this there?

Personally, I think it's fine to have a small self-contained
testcase that deals mostly with scoping vs recursion. I actually
like it better that way, but I know people may prefer it the other
way. My opinion for liking smaller testcases is that it's usually
easier to reproduce the problem: You don't have to sort through
a lot of unrelated stuff that happens before the problem occurs.

-- 
Joel


  parent reply	other threads:[~2011-12-28  3:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27 21:25 Paul Hilfinger
2011-12-28  1:38 ` Doug Evans
2011-12-28  3:43   ` Paul Hilfinger
2011-12-28  4:04   ` Joel Brobecker [this message]
2011-12-28 15:57     ` Paul Hilfinger
2011-12-29 11:10       ` Joel Brobecker
2011-12-28 18:02     ` Doug Evans
2011-12-30 22:27 Paul Hilfinger
2011-12-31  7:05 ` Joel Brobecker
2011-12-31 15:12   ` Paul Hilfinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111228035045.GK23376@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Hilfinger@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox