Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Hilfinger <Hilfinger@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add testcase for locals identified with FUNCTION::VAR syntax.
Date: Wed, 28 Dec 2011 03:43:00 -0000	[thread overview]
Message-ID: <20111228013829.7A58D92BF6@kwai.gnat.com> (raw)
In-Reply-To: <CADPb22Sxrmu9Hy20UYG4-xVWdW8ihfO_5RX_vQL2OJT6H7eUxA@mail.gmail.com>	(message from Doug Evans on Tue, 27 Dec 2011 16:58:14 -0800)


> Date: Tue, 27 Dec 2011 16:58:14 -0800
> From: Doug Evans <dje@google.com>
> Cc: gdb-patches@sourceware.org
> Content-Type: text/plain; charset=ISO-8859-1
> 
> On Tue, Dec 27, 2011 at 11:59 AM, Paul Hilfinger <Hilfinger@adacore.com> wrote:
> >
> > This test (from Joel Brobecker) stops inside a recursive function
> > after a few levels of recursion, goes up some frames, and then
> > accesses a local variable with 'print foo::val' rather than the usual
> > 'print val' to see if the former pays attention to the selected frame.
> >
...
> > +
> > +# Some convenient regular expressions...
> > +set num "\[0-9\]+"
> 
> Delete, use $decimal.

OK.

> > +set addr "0x\[0-9a-zA-Z\]+"
> 
> This could be replaced with $hex, or do "set addr $hex".  Either is
> fine with me.

OK.

> 
> > +
> > +gdb_test "break $srcfile:[gdb_get_line_number BREAK $srcfile] if n == 3" \
> > +         "Breakpoint $num at $addr: file .*recpar\\.c, line $num\\."
> > +
> > +gdb_test "continue" \
> > +         "Breakpoint .* foo \\(n=3\\) at .*$srcfile:$num.*"
> > +
> > +gdb_test "backtrace" \
> > +         "#0 +foo \\(n=3\\).*\r\n#1.* foo \\(n=4\\).*\r\n#2.* foo \\(n=5\\).*#3.* main \\(\\).*"
> > +
> > +gdb_test "frame 2" \
> > +         "#2 .* foo \\(n=5\\) .*"
> > +
> > +# In the currently selected frame, n=5, and thus foo::val should be 5
> > +# as well.
> > +gdb_test "print foo::val" \
> > +         " = 5"
> > --

> I notice scope.exp has similar tests.
> Would it make sense to move this there?
> 

I defer to whatever consensus develops.  All the tests in scope.c that use "::" 
stick to static variables, whereas the new test uses :: in an admittedly
undocumented fashion and concerns dynamic, rather than static, scoping. However,
I don't know what criteria there are for grouping tests.  

Thanks for your comments.

-- 
Paul N. Hilfinger
(Hilfinger@adacore.com)


  reply	other threads:[~2011-12-28  1:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27 21:25 Paul Hilfinger
2011-12-28  1:38 ` Doug Evans
2011-12-28  3:43   ` Paul Hilfinger [this message]
2011-12-28  4:04   ` Joel Brobecker
2011-12-28 15:57     ` Paul Hilfinger
2011-12-29 11:10       ` Joel Brobecker
2011-12-28 18:02     ` Doug Evans
2011-12-30 22:27 Paul Hilfinger
2011-12-31  7:05 ` Joel Brobecker
2011-12-31 15:12   ` Paul Hilfinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111228013829.7A58D92BF6@kwai.gnat.com \
    --to=hilfinger@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox