From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: valery.khromov@gmail.com
Cc: alves.ped@gmail.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64
Date: Tue, 20 Dec 2011 19:44:00 -0000 [thread overview]
Message-ID: <201112201931.pBKJV4bh021140@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <ED59EC2B-8A8A-4A79-8275-ABF6ABDB8E13@gmail.com> (message from Valery Khromov on Tue, 20 Dec 2011 20:47:53 +0300)
> From: Valery Khromov <valery.khromov@gmail.com>
> Date: Tue, 20 Dec 2011 20:47:53 +0300
>
> On 20.12.2011, at 19:05, Pedro Alves wrote:
>
> > On Tuesday 20 December 2011 15:03:09, Mark Kettenis wrote:
> >>> From: Valery Khromov <valery.khromov@gmail.com>
> >>> Date: Tue, 6 Dec 2011 04:54:24 +0400
> >>>
> >>> This patch provides hardware breakpoint/watchpoint support for
> >>> FreeBSD/AMD64. Most of the code is borrowed from the i386 implementation.
> >>
> >> I fear that since the recent changes that Pedro made, the code needs
> >> to be resycnhed with the i386 version :(. Can you do that?
> >
> > Yeah, sorry about that. I was actually planning on taking the
> > hit myself and updating Valery's patch. Let me know if you'd
> > like me to do it.
>
> See the following e-mails for fixes.
>
> I prefer not to change my original patch because FreeBSD still uses
> gdb 7.3.1 in ports and this fixes incompatible with it.
Sorry, you'll have to send a single diff against the current GDB CVS
sources for this, with a single Changelog entry. Diffs on top of
diffs are hard to review, and there is no point in having
intermediate/broken steps in our CVS repository.
next prev parent reply other threads:[~2011-12-20 19:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 2:41 Valery Khromov
2011-12-20 14:52 ` Tom Tromey
2011-12-20 18:30 ` Valery Khromov
2011-12-21 6:45 ` Joel Brobecker
2011-12-20 15:04 ` Mark Kettenis
2011-12-20 16:12 ` Pedro Alves
2011-12-20 17:52 ` Valery Khromov
2011-12-20 17:53 ` [PATCH 1/2] FreeBSD/amd64: Updates for the recent changes that Pedro Alves made Valery Khromov
2011-12-20 17:56 ` [PATCH 2/2] FreeBSD: Removed definition of DBREG_DRX macro because it is already in FreeBSD Valery Khromov
2011-12-20 19:44 ` Mark Kettenis [this message]
2011-12-20 20:38 ` [PATCH v2] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64 Valery Khromov
2012-01-31 17:50 ` Valery Khromov
2012-02-01 20:27 ` Tom Tromey
2012-02-02 9:03 ` Valery Khromov
2012-02-11 18:51 ` Mark Kettenis
2012-02-11 21:03 ` Valery Khromov
2012-02-09 16:10 ` Pedro Alves
2011-12-20 16:05 ` [PATCH] " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112201931.pBKJV4bh021140@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=alves.ped@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=valery.khromov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox