From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7813 invoked by alias); 20 Dec 2011 19:31:25 -0000 Received: (qmail 7805 invoked by uid 22791); 20 Dec 2011 19:31:25 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_CN X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Dec 2011 19:31:11 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id pBKJV6fG011607; Tue, 20 Dec 2011 20:31:06 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id pBKJV4bh021140; Tue, 20 Dec 2011 20:31:04 +0100 (CET) Date: Tue, 20 Dec 2011 19:44:00 -0000 Message-Id: <201112201931.pBKJV4bh021140@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: valery.khromov@gmail.com CC: alves.ped@gmail.com, gdb-patches@sourceware.org In-reply-to: (message from Valery Khromov on Tue, 20 Dec 2011 20:47:53 +0300) Subject: Re: [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64 References: <1323132864-14029-1-git-send-email-valery.khromov@gmail.com> <201112201503.pBKF390e027750@glazunov.sibelius.xs4all.nl> <201112201605.28313.alves.ped@gmail.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00696.txt.bz2 > From: Valery Khromov > Date: Tue, 20 Dec 2011 20:47:53 +0300 > > On 20.12.2011, at 19:05, Pedro Alves wrote: > > > On Tuesday 20 December 2011 15:03:09, Mark Kettenis wrote: > >>> From: Valery Khromov > >>> Date: Tue, 6 Dec 2011 04:54:24 +0400 > >>> > >>> This patch provides hardware breakpoint/watchpoint support for > >>> FreeBSD/AMD64. Most of the code is borrowed from the i386 implementation. > >> > >> I fear that since the recent changes that Pedro made, the code needs > >> to be resycnhed with the i386 version :(. Can you do that? > > > > Yeah, sorry about that. I was actually planning on taking the > > hit myself and updating Valery's patch. Let me know if you'd > > like me to do it. > > See the following e-mails for fixes. > > I prefer not to change my original patch because FreeBSD still uses > gdb 7.3.1 in ports and this fixes incompatible with it. Sorry, you'll have to send a single diff against the current GDB CVS sources for this, with a single Changelog entry. Diffs on top of diffs are hard to review, and there is no point in having intermediate/broken steps in our CVS repository.