From: Pedro Alves <alves.ped@gmail.com>
To: gdb-patches@sourceware.org
Cc: Valery Khromov <valery.khromov@gmail.com>
Subject: Re: [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64
Date: Tue, 20 Dec 2011 16:05:00 -0000 [thread overview]
Message-ID: <201112201602.54009.alves.ped@gmail.com> (raw)
In-Reply-To: <1323132864-14029-1-git-send-email-valery.khromov@gmail.com>
On Tuesday 06 December 2011 00:54:24, Valery Khromov wrote:
> + /* FIXME: kettenis/2001-03-31: Calling perror_with_name if the
> + ptrace call fails breaks debugging remote targets. The correct
> + way to fix this is to add the hardware breakpoint and watchpoint
> + stuff to the target vector. For now, just return zero if the
> + ptrace call fails. */
This is no longer necessary, and was recently removed everywhere. See:
<http://sourceware.org/ml/gdb-patches/2011-12/msg00139.html>
> + if (ptrace (PT_GETDBREGS, PIDGET (inferior_ptid),
> + (PTRACE_TYPE_ARG3) &dbregs, 0) == -1)
> +#if 0
> + perror_with_name (_("Couldn't read debug registers"));
> +#else
> + return 0;
> +#endif
--
Pedro Alves
prev parent reply other threads:[~2011-12-20 16:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 2:41 Valery Khromov
2011-12-20 14:52 ` Tom Tromey
2011-12-20 18:30 ` Valery Khromov
2011-12-21 6:45 ` Joel Brobecker
2011-12-20 15:04 ` Mark Kettenis
2011-12-20 16:12 ` Pedro Alves
2011-12-20 17:52 ` Valery Khromov
2011-12-20 17:53 ` [PATCH 1/2] FreeBSD/amd64: Updates for the recent changes that Pedro Alves made Valery Khromov
2011-12-20 17:56 ` [PATCH 2/2] FreeBSD: Removed definition of DBREG_DRX macro because it is already in FreeBSD Valery Khromov
2011-12-20 19:44 ` [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64 Mark Kettenis
2011-12-20 20:38 ` [PATCH v2] " Valery Khromov
2012-01-31 17:50 ` Valery Khromov
2012-02-01 20:27 ` Tom Tromey
2012-02-02 9:03 ` Valery Khromov
2012-02-11 18:51 ` Mark Kettenis
2012-02-11 21:03 ` Valery Khromov
2012-02-09 16:10 ` Pedro Alves
2011-12-20 16:05 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112201602.54009.alves.ped@gmail.com \
--to=alves.ped@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=valery.khromov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox