From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7720 invoked by alias); 20 Dec 2011 16:03:13 -0000 Received: (qmail 7707 invoked by uid 22791); 20 Dec 2011 16:03:11 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Dec 2011 16:02:58 +0000 Received: by wibhq12 with SMTP id hq12so1922991wib.0 for ; Tue, 20 Dec 2011 08:02:57 -0800 (PST) Received: by 10.181.13.162 with SMTP id ez2mr5992784wid.17.1324396977298; Tue, 20 Dec 2011 08:02:57 -0800 (PST) Received: from scottsdale.localnet (bl21-170-26.dsl.telepac.pt. [2.82.170.26]) by mx.google.com with ESMTPS id ep16sm2458609wbb.21.2011.12.20.08.02.55 (version=SSLv3 cipher=OTHER); Tue, 20 Dec 2011 08:02:56 -0800 (PST) From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64 Date: Tue, 20 Dec 2011 16:05:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-13-generic; KDE/4.7.2; x86_64; ; ) Cc: Valery Khromov References: <1323132864-14029-1-git-send-email-valery.khromov@gmail.com> In-Reply-To: <1323132864-14029-1-git-send-email-valery.khromov@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201112201602.54009.alves.ped@gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00679.txt.bz2 On Tuesday 06 December 2011 00:54:24, Valery Khromov wrote: > + /* FIXME: kettenis/2001-03-31: Calling perror_with_name if the > + ptrace call fails breaks debugging remote targets. The correct > + way to fix this is to add the hardware breakpoint and watchpoint > + stuff to the target vector. For now, just return zero if the > + ptrace call fails. */ This is no longer necessary, and was recently removed everywhere. See: > + if (ptrace (PT_GETDBREGS, PIDGET (inferior_ptid), > + (PTRACE_TYPE_ARG3) &dbregs, 0) == -1) > +#if 0 > + perror_with_name (_("Couldn't read debug registers")); > +#else > + return 0; > +#endif -- Pedro Alves