From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Hui Zhu <teawater@gmail.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [obv] Fix unused-but-set-variable error [Re: [OB] Fix linux-low.c build error]
Date: Mon, 19 Dec 2011 03:34:00 -0000 [thread overview]
Message-ID: <20111219032151.GL21915@adacore.com> (raw)
In-Reply-To: <20111218205826.GA15385@host2.jankratochvil.net>
In this case, I think that the warning was helpful regardless of
the version of GCC that emitted it. However, I did think that Hui's
solution was only sweeping the problem under the carpet and that
did make me uncomfortable.
> Checked in this alternative fix to not break the next nightly builds.
I much prefer your solution which makes it obvious that we decided
to ignore write errors.
--
Joel
next prev parent reply other threads:[~2011-12-19 3:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 16:05 [OB] Fix linux-low.c build error Hui Zhu
2011-12-18 20:58 ` Jan Kratochvil
2011-12-18 22:55 ` [obv] Fix unused-but-set-variable error [Re: [OB] Fix linux-low.c build error] Jan Kratochvil
2011-12-19 3:22 ` Hui Zhu
2011-12-19 3:34 ` Joel Brobecker [this message]
2011-12-19 6:50 ` Yao Qi
2011-12-19 6:53 ` Joel Brobecker
2011-12-19 8:13 ` Yao Qi
2011-12-19 9:32 ` Joel Brobecker
2011-12-19 10:23 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219032151.GL21915@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox